-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docsprint to reflect the new xapian-letor. #18
base: master
Are you sure you want to change the base?
Conversation
As I mentioned on IRC, this cannot maintain the structure of the documentation file from You should look at the rest of the repo to see how examples are done. They should be complete programs, out of which specific line ranges are included in the documentation. You'll have to write the examples in C++ (because language bindings aren't available for letor yet). The way this is done will also provide syntax highlighting for the code snippets. And you must build documentation and look at it before opening a pull request. This PR has a number of RST syntax errors and incorrect uses which are obvious as soon as you look at the rendered output. This is the documentation equivalent of tidying up C++ source code: it must build without errors, and it should follow the conventions already established in the rest of the documentation, as far as possible. A final note: all the stuff about extendability should be removed. As it stands, it's either obvious (to add a new I suggest you make the relevant changes then force push a new commit, and then add a comment here to indicate that it's ready for review; right now there are enough issues you can pick up yourself from the above without it being worth pointing every single one out, and given the need to restructure the document, I think fixup commits are going to be hard to follow. |
a7a1dd2
to
28aaf3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update - a few minor things:
Hi, |
@AyushP123 let me know if I can help with any of those issues. Also what do you think about adding documentation of xapian-letor-update in the main repository?. |
I'd suggest it's probably worth addressing the last few issues here first so we can merge this first as it's already a significant improvement over the current situation. Then a new PR can build on that. |
@@ -29,7 +29,7 @@ using namespace std; | |||
|
|||
static void show_usage() | |||
{ | |||
cout << "Usage: search_letor --db=DBPATH MODEL_METADATA_KEY QUERY\n"; | |||
cout << "Usage: search_letor MODEL_METADATA_KEY QUERY\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is wrong - it's only the --db=
part which isn't expected - the DBPATH
part is.
you have 'title' information in the collection with some xml/html tag or so | ||
then add:: | ||
|
||
indexer.index(title,1,"S"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting spaces after the commas in code would better match the other code examples.
I have updated the docsprint to account for changes in xapian-letor.