Skip to content

fix(cargo): prevent unnecessary rebuilds for registry crates #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Goldziher merged 1 commit into from
Jul 7, 2026
Merged

fix(cargo): prevent unnecessary rebuilds for registry crates #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions crates/ts-pack-core/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -841,7 +841,10 @@ fn generate_queries_registry(definitions: &BTreeMap<String, LanguageDefinition>,
}
match candidate.parent() {
Some(p) => candidate = p,
None => break,
None => {
candidate = &manifest_dir;
break;
}
}
}
candidate.join("query-overlays")
Expand Down Expand Up @@ -897,7 +900,9 @@ fn generate_queries_registry(definitions: &BTreeMap<String, LanguageDefinition>,

// Emit rerun triggers for the overlay directory itself so adding a new overlay
// file causes a rebuild even before any language list changes.
println!("cargo:rerun-if-changed={}", overlays_dir.display());
if overlays_dir.exists() {
println!("cargo:rerun-if-changed={}", overlays_dir.display());
}

// Helper: generate a query lookup function, or just return None if empty.
// We read query file contents at build time and embed them as string literals
Expand Down Expand Up @@ -1313,7 +1318,10 @@ fn main() {
continue;
}

emit_rerun_if_changed(&parser_dir);
let out_dir = env::var("OUT_DIR").unwrap_or_default();
if !parser_dir.starts_with(&out_dir) {
emit_rerun_if_changed(&parser_dir);
}

let ok = match link_mode.as_str() {
"static" => {
Expand Down
Loading