Skip to content

[script.audiooffsetmanager@nexus] 2.0.0 - #2859

Closed
matthane wants to merge 1 commit into
xbmc:nexusfrom
matthane:script.audiooffsetmanager@nexus
Closed

[script.audiooffsetmanager@nexus] 2.0.0#2859
matthane wants to merge 1 commit into
xbmc:nexusfrom
matthane:script.audiooffsetmanager@nexus

Conversation

@matthane

Copy link
Copy Markdown

Add-on details:

This add-on intelligently adjusts the audio offset based on the detected HDR type, audio format, and FPS type according to user-configured settings, along with other helpful features

Description of changes:

v2.0.0 (2026-07-16)

  • More reliable offset application: stream changes are detected and verified before offsets are applied, eliminating misapplied offsets during playback startup and format switches
  • Manual offset adjustments are now detected from any input method (keymaps, remotes, JSON-RPC), not just the Kodi audio settings dialog
  • Smarter notifications: they wait for the stream to settle, and no longer get cut short when two notifications arrive close together
  • Improved coexistence with PM4K (Plexmod for Kodi): seek-backs are announced via the script.audiooffsetmanager.seeking window property
  • New Advanced settings category with a debug logging toggle
  • Smaller package: the onboarding test video is now a lightweight dummy clip

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

@kodiai

kodiai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Kodiai Addon Check

✅ No issues found by kodi-addon-checker.

Kodi Add-on Rule Review

Rules source: https://kodi.wiki/view/Add-on_rules

Addon Level Source Message
script.audiooffsetmanager ERROR deterministic Missing license file in changed addon directory.

1 error(s), 0 warning(s) found by addon-rule review.

@matthane

Copy link
Copy Markdown
Author

Fighting with Kodi add-on submitter. I will be back, eventually with a correct PR.

@matthane matthane closed this Jul 18, 2026
@kodiai

kodiai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Decision: NOT APPROVED

Issues:

  • Kodiai found 1 unpublished finding that requires human review.
  • Bounded severity summary: 1 critical, 0 major, 0 medium, 0 minor.
  • Review output did not publish these findings inline: fix-eligibility-blocked
  • Raw finding text was kept private; see Review Details for bounded counts and publication diagnostics.
Review Details
  • Review plan: ready hash=57227848b811 route=standard task=review.full files=23 lines=10248(local-diff) budget=na/973s gates=3/3 publish=canonical-visible-surface graph=skipped candidates=preferred doctrine=disabled/0/0/0 reasons=disabled

  • Review reducer: ready input=1 kept=1 suppressed=0 rewritten=0 deprioritized=0 lowConfidence=0 auditEvents=0 severityDemoted=0 graphValidated=0 graphUncertain=0 doctrine=disabled/0/0/0 reasons=disabled

  • Review candidates: shadow recorded=1 rejected=0 errors=0 artifact=present repo=xbmc-repo-scripts pr=2859 key=kodiai-review-output:v1:inst-109141824:xbmc-repo-scripts:pr-2859:action-opened:d delivery=2ac5afb0-8271-11f1-8d86-7dbf31feaa9d

  • Review candidate publication: mode=blocked approved=1 rewritten=0 publishable=0 nonPublishable=1 fixBlocked=1 published=0 directFallback=0 reasons=fix-eligibility-blocked movedToDetails=0 detailsOmitted=0 buckets=blocked:1:fix-eligibility-blocked+missing-replacement

  • M072 candidate publication bridge: status=denied; bridgeVersion=candidate-publication-bridge.v1; bridgeId=candidate-publication-record:e71a4aea3e3bbffba0f244dbedae92d5; recordKey=candidate-publication-record:e71a4aea3e3bbffba0f244dbedae92d5; correlationKey=candidate-publication-bridge:c93ca82e22fc3c7b5dbfe82edea23051; source=review-handler-publication; candidateRef=candidate-publication-summary-0967b509; verification=none; counts=candidateCount:0,evidenceCount:0,verifiedCount:0,partiallyVerifiedCount:0,unverifiedCount:0,disprovenCount:0,publicationEligibleCount:0,malformedRecordCount:0,unsafeInputFieldCount:0; reasons=no-evidence,publication-ineligible; malformed=none; presence=deliveryId:y,reviewOutputKey:y,upstreamCorrelationKey:y,policyCorrelationKey:y; handoffOwner=available; redaction=privateOnly:y,rawPayloads:n,publicationFields:n,evidencePayloads:n,githubCommentBody:n,reducerRawPayload:n,discardedRawPayload:n,discardedPublicationFields:n,discardedEvidencePayloads:n

  • Review finding lifecycle: status=normalized; counts=input:1,recorded:1,rejected:0,unsafeInputFields:0; correlation=repo:y,pull:y,reviewOutputKey:y,deliveryId:y,commit:y; statuses=detected:1,open:1,suggested:0,validated:0,revalidated:0,resolved:0,blocked:0,degraded:0; severity=critical:1,major:0,medium:0,minor:0; actionability=actionable:0,needs-human-review:1,needs-reproduction:0,blocked:0,not-actionable:0; reasons=automatic-detected,automatic-open,automatic-review; rejected=none; redaction=privateOnly:y,rawPrompts:n,rawModelOutput:n,candidateBodies:n,toolPayloads:n,secretLike:n,diffs:n,unboundedArrays:n,unsafeFields:0

  • Review validation truth: status=normalized; counts=detected:1,suggested:0,validated:0,revalidated:0,resolved:0,blocked:0,degraded:0,open:1,uncertain:0,inputFindings:1,unsafeInputFields:0; evidence=fresh:0,stale:0,missingValidation:1,missingRevalidation:1; reasons=validation-missing:1; refs=rfl-f56c349fbce769d1:open:validation-missing:fix:n:validation:n:revalidation:n; correlation=reviewOutputKey:y,deliveryId:y; redaction=privateOnly:y,rawPrompts:n,rawModelOutput:n,candidateBodies:n,replacementText:n,toolPayloads:n,secretLike:n,diffs:n,unboundedArrays:n,unsafeFields:0

  • Files reviewed: 23

  • Findings: 0 critical, 0 major, 0 medium, 0 minor

  • Lines changed: +0 -10248

  • Profile: minimal (auto, lines changed: 10248)

  • Contributor experience: profile-backed (using linked contributor profile guidance)

  • Shadow specialist: lane=docs-config-truth status=skipped reason=no-candidates candidateCount=0 decisionCount=0 decisionCounts=candidate:0,duplicate:0,disagreement:0,dismissed:0,unclassifiable:0 duplicateCount=0 disagreementCount=0 dismissedCount=0 unclassifiableCount=0 truncatedCandidateCount=0 metricAvailability=token:n,cost:n,latency:n visiblePublicationDenied=true approvalPublicationDenied=true privateOnly=true shadowOnly=true redacted=raw:n,publication:n,approval:n,unsafe:0 correlationKey=ccbc017574c4b9e9 deliveryId=2ac5afb0-8271-11f1-8d86-7dbf31f… reviewOutputKey=kodiai-review-output:v1:inst-10…

  • Review completed: 2026-07-18T06:28:38.526Z

  • Total wall-clock: 5m 19s

  • Phase timings:

    • queue wait: 0ms
    • workspace preparation: 2.0s
    • retrieval/context assembly: 4.5s
    • executor handoff: 39s
    • remote runtime: 4m 31s
    • publication: 98ms (degraded: captured before publication completed)
  • Tokens: 111,327 in / 11,220 out | 0.5337

  • Keyword parsing: No keywords detected

  • Budget behavior: scoped (prompt-budget-limited).

  • Prompt budget: 5 sections, 1 trimmed, 0 bypassed, 116550 trimmed tokens.

  • Cache behavior: 2 observations, 1 hits, 1 misses, 0 degraded, 0 bypassed.

  • Continuation behavior: 0 observations, 0 compacted, 0 fallback, 0 degraded, 0 bypassed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant