Skip to content

[script.module.pyrollbar@matrix] 1.4.0 - #2861

Merged
romanvm merged 1 commit into
xbmc:matrixfrom
zim514:script.module.pyrollbar@matrix
Jul 25, 2026
Merged

[script.module.pyrollbar@matrix] 1.4.0#2861
romanvm merged 1 commit into
xbmc:matrixfrom
zim514:script.module.pyrollbar@matrix

Conversation

@zim514

@zim514 zim514 commented Jul 18, 2026

Copy link
Copy Markdown

Add-on details:

Python notifier for reporting exceptions, errors, and log messages to Rollbar.

Description of changes:

Update Rollbar API to 1.4.0

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

@romanvm romanvm added the Approved Approved and is ready to merge label Jul 19, 2026
@keithah

keithah commented Jul 20, 2026

Copy link
Copy Markdown
Member

@kodiai review

@xbmc xbmc deleted a comment from kodiai Bot Jul 20, 2026
@xbmc xbmc deleted a comment from kodiai Bot Jul 20, 2026
@xbmc xbmc deleted a comment from kodiai Bot Jul 20, 2026
@xbmc xbmc deleted a comment from kodiai Bot Jul 20, 2026
@xbmc xbmc deleted a comment from kodiai Bot Jul 20, 2026
@kodiai

kodiai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Kodiai Add-on Review

Summary

Reviewed 1 changed addon on matrix across 23 scoped patches in 17 evidence chunks. Found 19 model-backed contextual rule findings.

Findings

  • ERROR script.module.pyrollbar/LICENSE: License file must be named LICENSE.txt; changed path is script.module.pyrollbar/LICENSE.
  • ERROR script.module.pyrollbar/lib/rollbar/kodi/__init__.py:1: Added text uses CRLF line endings; Kodi add-on text files must use UNIX LF line endings.
  • ERROR script.module.pyrollbar/lib/rollbar/__init__.py:477: External endpoint parameter configures transmission of telemetry data to api.rollbar.com, implementing prohibited client-side analytics.
  • ERROR script.module.pyrollbar/lib/rollbar/__init__.py:468: IP address capture parameter enables collection of personally identifiable information for external telemetry transmission.
  • ERROR script.module.pyrollbar/lib/rollbar/__init__.py:472: Email capture parameter enables collection of PII for external analytics transmission.
  • ERROR script.module.pyrollbar/lib/rollbar/__init__.py:473: Username capture parameter enables collection of PII for external analytics transmission.
  • ERROR script.module.pyrollbar/lib/rollbar/__init__.py:485: HTTP proxy configuration parameter enables transmission of reports to Rollbar service through proxy servers.
  • ERROR script.module.pyrollbar/lib/rollbar/__init__.py:535: Thread pool handler initialization enables asynchronous transmission of collected telemetry and error data.
  • ERROR script.module.pyrollbar/lib/rollbar/__init__.py:677: Function send_payload directly transmits exception data, session information, and user details to external services via HTTP, violating the analytics transmission rule.
  • WARN script.module.pyrollbar/lib/rollbar/__init__.py:1627: Functions (lines 1353–1400, 1405–1625, 1627–1628) build request/error data payloads for Rollbar telemetry transmission service. Kodi rules forbid direct analytics/telemetry transmission in addons. Confirm whether module exceptions apply.
  • ERROR script.module.pyrollbar/lib/rollbar/cli.py:15: Direct transmission of telemetry to Rollbar service via rollbar.report_message(). Kodi rules prohibit direct usage of analytics within add-ons.
  • ERROR script.module.pyrollbar/lib/rollbar/__init__.py:1731: Function _send_payload_pool() transmits payload to external Rollbar API endpoint. Direct analytics transmission violates Kodi submission rules.
  • ERROR script.module.pyrollbar/lib/rollbar/__init__.py:1869: Function _send_payload_httpx() transmits payload via httpx to Rollbar 'item/' endpoint. This constitutes prohibited direct analytics usage.
  • ERROR script.module.pyrollbar/lib/rollbar/kodi/__init__.py:41: Direct initialization of external analytics service Rollbar violates Kodi rule prohibiting analytics transmission from addons.
  • ERROR script.module.pyrollbar/lib/rollbar/kodi/__init__.py:42: Direct transmission of error and system data to external Rollbar service violates prohibition on analytics use from addons.
  • ERROR script.module.pyrollbar/lib/rollbar/lib/_async.py:44: Function report_exc_info reports exceptions to Rollbar servers. Direct analytics/telemetry transmission from add-ons is prohibited; this must be handled server-side using user-agent.
  • ERROR script.module.pyrollbar/lib/rollbar/lib/_async.py:78: Function report_message reports messages to Rollbar servers. Direct analytics/telemetry transmission from add-ons is prohibited; this must be handled server-side using user-agent.
  • ERROR script.module.pyrollbar/lib/rollbar/lib/_async.py:138: Code directly transmits error tracking data to external Rollbar service via HTTP POST, violating the ban on analytics/telemetry transmission from add-ons.
  • WARN script.module.pyrollbar/lib/rollbar/lib/thread_pool.py:38: Module submits payloads with access tokens to external services. Verify that analytics transmission requires explicit dependent add-on initialization and does not auto-occur on module import.
  • WARN script.module.pyrollbar/lib/rollbar/lib/transforms/batched.py:1: Add-on is the Rollbar analytics library designed to transmit telemetry to external servers, which may violate the usage-analytics rule.
  • ERROR script.module.pyrollbar/lib/rollbar/logger.py:86: RollbarHandler initializes Rollbar error reporting service without user consent mechanism, enabling automatic telemetry transmission to external servers

Verdict

Needs human review: 18 errors and 3 warnings found. Final approval remains with a human reviewer.

@romanvm romanvm added Approved Approved and is ready to merge and removed Approved Approved and is ready to merge labels Jul 25, 2026
@romanvm
romanvm merged commit 51304a4 into xbmc:matrix Jul 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Approved and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants