-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure commas in numbers for legibility #130 #266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@BrandtH22 @Rigidity this is ready for review. I believe I did a thorough job of finding places where amounts should be formatted but I likely missed a spot or two. |
This reverts commit d83e8ca.
- fix duplicate display of usd balance - simplify price tooltip for cats by getting the price directly
just did a merge form main. picked up an extra commit that i did not intend. low risk change to add more columns to the token grid on larger screens. 8a345ef |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces number localization for amount values. #130
navigator.language
isnumber.toLocaleString
walletState.sync.unit.decimals
and 3 for CATSfromMojos
used in a number of places instead oftoDecimal
to avoid number to string to number to stringformatNumber
to wraptoLocaleString
and handle type conversionsNumberFormat
component for inclusion in markupThis same pattern can be used for DateTimes when the show up (#243)