Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches transaction construction and fee handling via a major SDK bump; reserved fees may change how XCH is selected for multi-action spends.
Overview
Upgrades
chia-wallet-sdkfrom 0.33.0 to 0.36.0 in the workspace and refreshesCargo.lock, pulling in newerchia-sdk-*crates (includingchia-sdk-daemon),rue-*0.8.5, and updatedchia-ssl/ crypto dependencies.The only Sage code change adapts to the SDK’s
FeeAction: when building transactions from API fee actions increate_transaction, fees are now passed withreserved: trueso the driver treats the fee amount as reserved during coin selection/spend planning.Reviewed by Cursor Bugbot for commit f61a632. Bugbot is set up for automated code reviews on this repo. Configure here.