-
Notifications
You must be signed in to change notification settings - Fork 108
Update documentation for new Windows PV tools #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Also remove outdated WPV 8.2 instructions. Signed-off-by: Tu Dinh <[email protected]>
59f95a0
to
3d7419e
Compare
Make sure to either check this checkbox, specify `ALLOWDRIVERINSTALL=YES` on the Msiexec command line (if installing via command line) or install driver updates via Windows Update. | ||
|
||
## PV devices not getting updates with the "Manage Citrix PV drivers via Windows Update" option enabled | ||
## When using the Citrix XenServer drivers, PV devices are not getting updates with the "Manage Citrix PV drivers via Windows Update" option enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Section titles in this page are quite long in general, which makes the navigation bar confusing to red. Can we make the title for this section shorter, then describe the issue in more detail (by including an introduction to that section)?
#### XCP-ng vs XenServer tools | ||
|
||
There exist two sets of Windows guest tools compatible with XCP-ng: XCP-ng's Windows Guest Tools and XenServer's Windows Guest Tools. | ||
There exist two sets of Windows guest tools compatible with XCP-ng: XCP-ng Windows PV Drivers and Citrix XenServer VM Tools for Windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There exist two sets of Windows guest tools compatible with XCP-ng: XCP-ng Windows PV Drivers and Citrix XenServer VM Tools for Windows. | |
There are two sets of Windows guest tools compatible with XCP-ng: **XCP-ng Windows PV Drivers** and **Citrix XenServer VM Tools for Windows**. |
|
||
###### Install the XCP-ng drivers | ||
##### Install the XCP-ng drivers | ||
0. Snapshot your VM before installing (just in case) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if this step is optional, I'd rather have something like:
1. (Optional) Snapshot your VM before installing (just in case).
The numbering starting at 0 seems quite unusual to me in this context.
Also, since we're dealing with complete sentences here (with conjugated verbs), I think we can end each entry from this list with a full stop.
##### Management agent + device drivers | ||
When using the Citrix XenServer VM Tools for Windows, the only way to get the management agent is from XenServer directly. | ||
It can be freely downloaded from the [XenServer download page](https://www.xenserver.com/downloads). | ||
The installer will install both the management agent and the device drivers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless the situation is ambiguous, I think 'and' is clear enough and we don't necessarily need the 'both' part.
##### Automated installation via Windows Update: device drivers alone (XenServer VM Tools only) | ||
In Xen Orchestra, you can switch the "Manage Citrix PV drivers via Windows Update" advanced parameter on from the "Advanced" tab of the VM view. This will install the device drivers automatically at next reboot :warning: **but not the management agent** which still needs to be installed from XenServer tools' installer. | ||
|
||
... So the "Manage Citrix PV drivers via Windows Update" option is not a complete solution if you need the guest metrics from the management agent. However it may be a convenient way to get future driver updates if you wish so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend against starting a sentence with 'So' (which connects two clauses within the same sentence), or with three dots. We can use a more appropriate phrase, like 'As a result', 'As we've seen', or something to that effect.
Co-authored-by: Thomas Moraine <[email protected]> Signed-off-by: dinhngtu <[email protected]>
Also remove outdated WPV 8.2 instructions.
The XCP-ng drivers are now the recommended drivers for Windows guests. Both sets of guest tools remain supported.