Skip to content

Add autoconf to the management interface in IPv6 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

Nambrok
Copy link

@Nambrok Nambrok commented Nov 14, 2023

Allows to configure the management interface in Autoconf when the interface primary type is IPv6.

Allows to configure the management interface in Autoconf when the
interface primary type is IPv6.

Signed-off-by: Damien Thenot <[email protected]>
@Nambrok
Copy link
Author

Nambrok commented Nov 14, 2023

@benjamreis

@benjamreis benjamreis self-requested a review November 14, 2023 09:24
@benjamreis benjamreis requested a review from stormi November 14, 2023 09:28
Copy link
Member

@stormi stormi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. One minor comment on formatting.

I let you decide with Benjamin what's best for the hostname question.

Regarding the feature, I don't see added code to handle the Autoconf choice once chosen by the user. Is setting self.mode all we have to do for it to be effective?

@benjamreis
Copy link

Regarding the feature, I don't see added code to handle the Autoconf choice once chosen by the user. Is setting self.mode all we have to do for it to be effective?

Yes as the reconfigure call are done with self.mode as an arg :)

@benjamreis benjamreis merged commit a8e86a7 into xcp-ng:adapt-for-ipv6 Nov 15, 2023
@Nambrok Nambrok deleted the adapt-for-ipv6 branch November 16, 2023 15:32
@benjamreis
Copy link

Upstream contribution included in xapi-project#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants