Add autoconf to the management interface in IPv6 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to configure the management interface in Autoconf when the interface primary type is IPv6. Signed-off-by: Damien Thenot <[email protected]>
benjamreis
reviewed
Nov 14, 2023
stormi
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
It looks good to me. One minor comment on formatting.
I let you decide with Benjamin what's best for the hostname question.
Regarding the feature, I don't see added code to handle the Autoconf choice once chosen by the user. Is setting self.mode all we have to do for it to be effective?
Yes as the reconfigure call are done with self.mode as an arg :) |
Signed-off-by: Damien Thenot <[email protected]>
benjamreis
approved these changes
Nov 15, 2023
|
Upstream contribution included in xapi-project#4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to configure the management interface in Autoconf when the interface primary type is IPv6.