Skip to content

Revise Compatibility System Ratings #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions generate.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,11 @@
'Unknown' : 'A compatibility test has not been recorded for this title.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Unknown' : 'A compatibility test has not been recorded for this title.',
It's a useless element because all the games have been tested! So it could be deleted !

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there are no titles with Unknown status at the moment, but we will keep the label around because:

  • Showing Unknown category, even with a value of 0, gives the reader the knowledge that there are no titles in the database with Unknown status (as opposed to having to guess if that's the case)
  • We may discover more titles that haven't been tested
  • We may show regional variants that have not been reported on

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there still a roadmap for compat
listings for beta games/development titles?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no roadmap for compat db improvements, just some thoughts in the form of issues in this repo

'Broken' : 'This title crashes very soon after launching, or displays nothing at all.',
'Intro' : 'This title displays an intro sequence, but fails to make it to gameplay.',
'Starts' : 'This title starts, but may crash or have significant issues.',
'Playable' : 'This title is playable, with minor issues.',
'Perfect' : 'This title is playable from start to finish with no noticable issues.'
}
'Starts' : 'This title starts, but may crash, have significant issues, or be unplayable.',
'Playable' : 'This title runs but has noticeable issues, graphical, audio, or performance issues that may affect gameplay.',
'Almost Perfect' : 'This title is playable with very minor graphical, audio, or performance issues.',
'Perfect' : 'This title is playable from start to finish with no noticeable issues.'
}

def get_field(s,x):
return s[x] if x in s else ''
Expand Down Expand Up @@ -236,6 +237,7 @@ def main():
'Intro' : 0,
'Starts' : 0,
'Playable' : 0,
'Almost Perfect' : 0,
'Perfect' : 0,
}

Expand Down
2 changes: 1 addition & 1 deletion templates/template_index.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{% set title_status_colors = {'Unknown' : '#2A2A2A', 'Broken' : '#D7263D', 'Intro' : '#F86624', 'Starts' : '#FF9800', 'Playable' : '#42991b', 'Perfect' : '#1b8799'} %}
{% set title_status_colors = {'Unknown' : '#2A2A2A', 'Broken' : '#D7263D', 'Intro' : '#F86624', 'Starts' : '#FF9800', 'Playable' : '#42991b', 'Almost Perfect' : '#2fe19a', 'Perfect' : '#1b8799'} %}

{% extends "template_base.html" %}
{% block append_head %}
Expand Down
2 changes: 1 addition & 1 deletion templates/template_title.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{% set title_status_colors = {'Unknown' : '#595959', 'Broken' : '#D7263D', 'Intro' : '#F86624', 'Starts' : '#FF9800', 'Playable' : '#42e335', 'Perfect' : '#1bdeff'} %}
{% set title_status_colors = {'Unknown' : '#2A2A2A', 'Broken' : '#D7263D', 'Intro' : '#F86624', 'Starts' : '#FF9800', 'Playable' : '#42991b', 'Almost Perfect' : '#2fe19a', 'Perfect' : '#1b8799'} %}
{% extends "template_base.html" %}
{% block title %}{{ title.title_name }} Compatibility{% endblock %}
{% block append_head %}
Expand Down
2 changes: 1 addition & 1 deletion templates/testing_priority.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{% set title_status_colors = {'Unknown' : '#595959', 'Broken' : '#D7263D', 'Intro' : '#F86624', 'Starts' : '#FF9800', 'Playable' : '#42e335', 'Perfect' : '#1bdeff'} %}
{% set title_status_colors = {'Unknown' : '#2A2A2A', 'Broken' : '#D7263D', 'Intro' : '#F86624', 'Starts' : '#FF9800', 'Playable' : '#42991b', 'Almost Perfect' : '#2fe19a', 'Perfect' : '#1b8799'} %}
{% extends "template_base.html" %}
{% block title %}Compatibility Priority Testing List{% endblock %}

Expand Down