Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_quote_period_interval() where interval/range doesn't work (Issue #60) #62

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix get_quote_period_interval() where interval/range doesn't work (Issue #60) #62

wants to merge 6 commits into from

Conversation

7jrxt42BxFZo4iAnN4CX
Copy link 

"{url}/{symbol}?symbol={symbol}&period={period}&interval={interval}&includePrePost={prepost}"

instead of

"{url}/{symbol}?symbol={symbol}&range={range}&interval={interval}&includePrePost={prepost}"

xemwebe
xemwebe reviewed Jan 15, 2025
View reviewed changes
Copy link
Owner

@xemwebe xemwebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please run cargo fmt on your PR with standard tab spacing? Otherwise it's quite difficult to review your changes since everything seems to have changes. Also, I do prefer four space wide intention anyway.

@7jrxt42BxFZo4iAnN4CX
Copy link
Author

Sorry, I completely forgot about this.

@7jrxt42BxFZo4iAnN4CX
Copy link
Author

now it should build

@7jrxt42BxFZo4iAnN4CX
Copy link
Author

7jrxt42BxFZo4iAnN4CX commented Jan 20, 2025 •
edited
Loading

@xemwebe Can we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xemwebe xemwebe xemwebe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@7jrxt42BxFZo4iAnN4CX @xemwebe