[LINUX/CPU/BASE] Added System-V ABI support in x64 backend & fixed mmap initialization #2228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guccigang420
force-pushed
the
system-v-abi-mmap
branch
from
2ba9f97 to
2638550
Compare
guccigang420
changed the title
guccigang420
force-pushed
the
system-v-abi-mmap
branch
from
2638550 to
75b958e
Compare
guccigang420
force-pushed
the
system-v-abi-mmap
branch
from
75b958e to
add1b00
Compare
|
This was required for me to get the CPU to work at all on Linux, before it was jumping to a random address due to the mismatched function arguments. |
RodoMa92
added a commit
to RodoMa92/xenia-canary
that referenced
this pull request
Jan 17, 2025
…#2228 back to canary builds. This fixes various emulation crashes caused from different calling conventions on System-V ABI platforms compared to the Windows standard.
RodoMa92
added a commit
to RodoMa92/xenia-canary
that referenced
this pull request
Jan 18, 2025
…#2228 back to canary builds. This fixes various emulation crashes caused from different calling conventions on System-V ABI platforms compared to the Windows standard.
RodoMa92
added a commit
to RodoMa92/xenia-canary
that referenced
this pull request
Jan 19, 2025
… for Linux Upstream changes made from xenia-project#1339 and xenia-project#2228 back to canary builds. This fixes various emulation crashes caused from different calling conventions on System-V ABI platforms compared to Windows standard.
Gliniak
pushed a commit
to xenia-canary/xenia-canary
that referenced
this pull request
Jan 19, 2025
… for Linux Upstream changes made from xenia-project#1339 and xenia-project#2228 back to canary builds. This fixes various emulation crashes caused from different calling conventions on System-V ABI platforms compared to Windows standard.
seven7000real
pushed a commit
to seven7000real/xenia-canary
that referenced
this pull request
May 24, 2025
… for Linux Upstream changes made from xenia-project#1339 and xenia-project#2228 back to canary builds. This fixes various emulation crashes caused from different calling conventions on System-V ABI platforms compared to Windows standard.
Triang3l
requested changes
Aug 15, 2025
| add(rsp, stack_size); | ||
| ret(); | ||
| #elif XE_PLATFORM_LINUX || XE_PLATFORM_MAC | ||
| // This function is being called using the Microsoft ABI from CallNative |
There was a problem hiding this comment.
We need to research the usage of registers in the guest instruction translation and probably change CallNativeSafe itself instead, there's no need to use the Microsoft calling convention anywhere on Linux. Instruction implementations calling native functions seem to use GetNativeParam, it possibly should be enough to modify GetNativeParam, though all call sites need to be checked carefully.
There was a problem hiding this comment.
#2018 already has the GetNativeParam changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current thunks in x64_backend.cc assumed that the calling convention is Microsoft ABI. Added an implementation for the System-V ABI which is used in Unix(-like) systems (Linux/MacOS/FreeBSD/etc).
When memory mapping a file, we should ensure it is large enough.
See:
https://wiki.osdev.org/System_V_ABI
https://man7.org/linux/man-pages/man2/mmap.2.html