Add webhooks config endpoint [ACC-2107] #144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschev
force-pushed
the
webhooks-endpoint
branch
from
35982ce to
edecebb
Compare
rschev
force-pushed
the
webhooks-endpoint
branch
from
d54d0af to
4719f11
Compare
rschev
force-pushed
the
webhooks-endpoint
branch
2 times, most recently
from
0878b5c to
b52b52e
Compare
Comment on lines
+17
to
+19
| @AutoConfiguration(before = { | ||
| JOOQQueryEngineAutoConfiguration.class, | ||
| }, after = { | ||
| RabbitAutoConfiguration.class, | ||
| }) |
There was a problem hiding this comment.
This does not have any conditional annotations that depend on RabbitAutoConfiguration having run, so that dependency is not necessary.
And the before ordering should probably be an after ordering on JOOQQueryEngineAutoConfiguration, because that is the configuration that has a dependency on this. Inverting the ordering like this is a bit confusing
There was a problem hiding this comment.
Without after = RabbitAutoConfiguration, the ObjectProvider will always be empty.
With after = JOOQ instead of before, it will have a duplicate bean with the noopEventHandlers.
...a/com/contentgrid/appserver/autoconfigure/query/engine/JOOQQueryEngineAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...-appserver-domain/src/main/java/com/contentgrid/appserver/domain/events/EntityFormatter.java
Outdated
Show resolved
Hide resolved
...query-engine-api/src/main/java/com/contentgrid/appserver/query/engine/api/EventConsumer.java
Outdated
Show resolved
Hide resolved
...query-engine-api/src/main/java/com/contentgrid/appserver/query/engine/api/EventConsumer.java
Outdated
Show resolved
Hide resolved
...-impl-jooq/src/test/java/com/contentgrid/appserver/query/engine/jooq/EventsDispatchTest.java
Outdated
Show resolved
Hide resolved
...-impl-jooq/src/test/java/com/contentgrid/appserver/query/engine/jooq/EventsDispatchTest.java
Outdated
Show resolved
Hide resolved
...-impl-jooq/src/test/java/com/contentgrid/appserver/query/engine/jooq/EventsDispatchTest.java
Outdated
Show resolved
Hide resolved
...rest/src/main/java/com/contentgrid/appserver/rest/ContentGridRestFormatterConfiguration.java
Outdated
Show resolved
Hide resolved
...rest/src/main/java/com/contentgrid/appserver/rest/ContentGridRestFormatterConfiguration.java
Outdated
Show resolved
Hide resolved
rschev
force-pushed
the
webhooks-endpoint
branch
from
e1d3fac to
0bccc84
Compare
rschev
force-pushed
the
webhooks-endpoint
branch
from
8ec1d03 to
be9c940
Compare
rschev
force-pushed
the
webhooks-endpoint
branch
from
be9c940 to
59d42ef
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.