-
Notifications
You must be signed in to change notification settings - Fork 1
[XEN-3146] Upgrade to AWS SDK 2.x #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
integration-tests/src/test/java/eu/xenit/solr/backup/s3/SolrBackupTest.java
Outdated
Show resolved
Hide resolved
solr-backup/src/main/java/eu/xenit/solr/backup/s3/S3OutputStream.java
Outdated
Show resolved
Hide resolved
solr-backup/src/main/java/eu/xenit/solr/backup/s3/S3BackupRepositoryConfig.java
Outdated
Show resolved
Hide resolved
solr-backup/src/main/java/eu/xenit/solr/backup/s3/S3OutputStream.java
Outdated
Show resolved
Hide resolved
pvriel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the comments I left behind. Nothing major, though ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the AWS SDK from version 1.x to version 2.x, addressing the obsolescence of SDK 1.x. The migration involves updating API calls, exception handling, and request/response patterns throughout the codebase to align with SDK 2.x conventions.
Key changes:
- Updated all AWS SDK imports from
com.amazonaws.*tosoftware.amazon.awssdk.* - Migrated from imperative API style to builder patterns for all S3 operations
- Replaced manual pagination with SDK 2.x paginator utilities
- Implemented custom progress tracking for multipart uploads
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| S3StorageClient.java | Core migration of S3 client initialization and all S3 operations to SDK 2.x APIs |
| S3OutputStream.java | Updated multipart upload implementation with SDK 2.x request/response patterns |
| S3BackupRepositoryConfig.java | Added new configuration properties and updated client builder integration |
| S3BackupRepository.java | Added URISyntaxException handling for client initialization |
| ProgressTrackingInputStream.java | New custom implementation to track upload progress |
| build.gradle files | Updated dependencies from AWS SDK 1.x BOM to 2.x BOM |
| solr.xml | Added new configuration properties for checksum validation and progress logging |
| docker-compose.yml | Added volume mount options and new environment variable |
| SolrBackupTest.java | Migrated test S3 client initialization to SDK 2.x |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AWS SDK 1.x is obsolete. This PR ports the implementation to version 2.x. Updated methods are annotated with a comment to explain the change in migration, these can be removed later if needed.