Skip to content

Conversation

@NotAPenguin0
Copy link

AWS SDK 1.x is obsolete. This PR ports the implementation to version 2.x. Updated methods are annotated with a comment to explain the change in migration, these can be removed later if needed.

@NotAPenguin0 NotAPenguin0 requested a review from pvriel October 20, 2025 13:27
Copy link

@pvriel pvriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the comments I left behind. Nothing major, though ;)

@NotAPenguin0 NotAPenguin0 requested a review from pvriel November 6, 2025 16:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the AWS SDK from version 1.x to version 2.x, addressing the obsolescence of SDK 1.x. The migration involves updating API calls, exception handling, and request/response patterns throughout the codebase to align with SDK 2.x conventions.

Key changes:

  • Updated all AWS SDK imports from com.amazonaws.* to software.amazon.awssdk.*
  • Migrated from imperative API style to builder patterns for all S3 operations
  • Replaced manual pagination with SDK 2.x paginator utilities
  • Implemented custom progress tracking for multipart uploads

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
S3StorageClient.java Core migration of S3 client initialization and all S3 operations to SDK 2.x APIs
S3OutputStream.java Updated multipart upload implementation with SDK 2.x request/response patterns
S3BackupRepositoryConfig.java Added new configuration properties and updated client builder integration
S3BackupRepository.java Added URISyntaxException handling for client initialization
ProgressTrackingInputStream.java New custom implementation to track upload progress
build.gradle files Updated dependencies from AWS SDK 1.x BOM to 2.x BOM
solr.xml Added new configuration properties for checksum validation and progress logging
docker-compose.yml Added volume mount options and new environment variable
SolrBackupTest.java Migrated test S3 client initialization to SDK 2.x

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants