Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
## v73.0.0-SNAPSHOT - unreleased

* Support for reporting Client Version in Admin WebSockets tab.
* ⚠️ Removed TS rule from DashViewSpec that allowed any type of additional values to be added to a DashViewSpec.
The rule defeats the goal of the DashViewSpec interface, which is to help guide app developers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TMI, I think. Ok to just say "Removed Incorrect TypeScript constraint..." and let the chips fall where they may

in writing DashViewSpecs. We don't think many apps were declaring additional values on DashViewSpecs.
If any were, these additional values would now be identified by the TS compiler as not permitted.

## v72.2.0 - 2025-03-13

Expand Down
15 changes: 12 additions & 3 deletions desktop/cmp/dash/DashViewSpec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*
* Copyright © 2025 Extremely Heavy Industries Inc.
*/
import {Content, Thunkable} from '@xh/hoist/core';
import {Content, RefreshMode, RenderMode, Thunkable} from '@xh/hoist/core';
import '@xh/hoist/desktop/register';
import {ReactElement} from 'react';

Expand Down Expand Up @@ -53,6 +53,15 @@ export interface DashViewSpec {
/** True (default) to allow renaming the view. */
allowRename?: boolean;

/** Additional properties to store on the DashView */
[x: string]: any;
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m pretty sure renderMode and refreshMode are specific to DashContainerViews (and already exist in the DashContainerViewSpec interface which extends this one):

export interface DashContainerViewSpec extends DashViewSpec {

* Strategy for rendering this view.
* See enum for description of supported modes.
*/
renderMode?: RenderMode;

/**
* Strategy for refreshing this view.
* See enum for description of supported modes.
*/
refreshMode?: RefreshMode;
}
Loading