Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Drinks #100

Merged
merged 13 commits into from
Sep 2, 2024
Merged

Custom Drinks #100

merged 13 commits into from
Sep 2, 2024

Conversation

zelzmiy
Copy link
Contributor

@zelzmiy zelzmiy commented Aug 27, 2024

Additions:

  • restructures the way Custom Meals are implemented in order to add Custom Drinks
  • fixes some bugs with the custom meals

Known Issues:

  • Followers eating/drinking the custom food will be shown holding the default "meal" or the default "bog brew". not planning to fix because i don't know how to work with Skins.

image

zelzmiy added 11 commits August 24, 2024 19:03
@zelzmiy
Merge pull request #1 from zelzmiy/dev
758c3dc 
Custom Meals and CustomMeaLEffects
@zelzmiy
Merge branch 'xhayper:main' into main
8beffb3
@zelzmiy
Complete CustomMeal Restructuring + Custom Drinks
e0b09f4 
i wanted to split this up into multiple commits for clarity but idk how to do that without breaking literally everything.
* Custom Drinks
* Restructuring of CustomMeal class
@zelzmiy
ItemDisplayOffset via hack
0f10cc9
@zelzmiy
Merge pull request #2 from zelzmiy/dev
47f7322 
Custom Drink Implementation (and restructuring)
@zelzmiy
fix: improper drink placement, scaling, and followercommand issues
50a645d
@zelzmiy
fix vomiting after eating a mea
39eddc7 
such an obvious oversight caused by my test meal having an vomiting MealEffect, i thought it was just part eating the meal..
@zelzmiy
fix: incorrect equality check
840b7b6 
oops
@zelzmiy
prevent repeated offsetting
0892ac7
@zelzmiy
fix: string.Empty
ad6483f 
https://cdn.discordapp.com/attachments/896788252634255391/1277810907518468137/image.png?ex=66ce85a4&is=66cd3424&hm=be005fc7b5b375820ffc408a34ba010d6a6c95a24a6d5a4002bf647f0ff62d34&
@zelzmiy
Merge pull request #3 from zelzmiy/dev
da1d345 
Fixed for Custom Drinks
@vercel Vercel
Copy link

vercel bot commented Aug 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
cotl-api ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2024 9:26pm

@github-actions github-actions bot added the API The core of this package label Aug 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

Download the artifacts for this pull request:

zelzmiy added 2 commits August 29, 2024 16:22
@zelzmiy
remove _Postfix from name
1e5c6c0 
accidentally left in front when I had a postfix and a prefix on that method, my bad :(
@zelzmiy
Merge pull request #4 from zelzmiy/dev
70a98cd 
remove _Postfix from name
@xhayper xhayper added the enhancement New feature or request label Aug 30, 2024
@InfernoDragon0 InfernoDragon0 merged commit 089279e into xhayper:main Sep 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InfernoDragon0 InfernoDragon0 InfernoDragon0 approved these changes

Assignees
No one assigned
Labels
API The core of this package enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zelzmiy @InfernoDragon0 @xhayper