Add Arm RTCD for OpenBSD #363
Open
+41
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jmvalin |
|
@jmvalin Ping. |
jmvalin
reviewed
Jul 18, 2025
| @@ -191,7 +191,7 @@ static opus_uint32 opus_cpu_capabilities(void) | |||
| return flags; | |||
| } | |||
|
|
|||
| #elif defined(__FreeBSD__) | |||
| #elif defined(HAVE_ELF_AUX_INFO) | |||
There was a problem hiding this comment.
I'm not sure I understand why you need to change the FreeBSD case to add OpenBSD. Not against your OpenBSD patch but would like to make sure we don't break FreeBSD. More specifically, your HAVE_ELF_AUX_INFO is added to only two out of the four build systems we support.
There was a problem hiding this comment.
Not every release of FreeBSD nor OpenBSD has the elf_aux_info() API. This is how I've done things with pretty much every other project I've added OpenBSD or FreeBSD/OpenBSD support. I have now added and fixed the CMake support.
brad0
force-pushed
the
openbsd_arm
branch
2 times, most recently
from
0e19c92 to
660aed0
Compare
|
Added CMake support. Also noticed a missed piece for FreeBSD while I was at it. |
Also fix FreeBSD CMake support on ARM.
|
The meson build system seems to be broken. meson-log.txt has.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix FreeBSD CMake support on ARM.