Skip to content

model loading error handling in denoise.c #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

model loading error handling in denoise.c #271

wants to merge 1 commit into from

Conversation

orvitpng
Copy link

This patch improves RNN model loading functions by:

  • Checking allocation return values before use
  • Validating file handles
  • Rejecting overly large file sizes (i.e., > INT_MAX)
  • Handling malloc(0) explicitly

Functionality should remain the same, but this removes undefined or implementation-defined behaviors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@henkelmax henkelmax henkelmax approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orvitpng @henkelmax