Adds support for the VIBrato command to SampleInstrument

sources/Application/Instruments/CommandList.cpp

@@ -36,6 +36,7 @@ static FourCC _all[] = {
     FourCC::InstrumentCommandTable,
     FourCC::InstrumentCommandTempo,
     FourCC::InstrumentCommandVelocity,
+    FourCC::InstrumentCommandVibrato,
     FourCC::InstrumentCommandVolume,
 };
 

sources/Application/Instruments/SRPUpdaters.cpp

@@ -8,8 +8,10 @@
  */
 
 #include "SRPUpdaters.h"
+#include "Foundation/Constants/SineTable.h"
 #include "System/Console/Trace.h"
 #include <math.h>
+
 //
 // Volume Ramp
 //
@@ -298,3 +300,34 @@ void Arp::UpdateSRP(struct RUParams &rup) {
     return;
   rup.speedOffset_ = fp_mul(rup.speedOffset_, current_);
 };
+
+//
+// Vibrato
+//
+
+void Vibrato::SetData(uint8_t rate, uint8_t depth) {
+  // lower 8 bits: depth, upper 8 bits: speed
+  depth_ = depth;
+  rate_ = 1 + (rate << 4);
+
+  // reset output and phase
+  phase_ = 0;
+  current_ = FP_ONE;
+};
+
+void Vibrato::Trigger(bool tableTick) {
+  if (!enabled_)
+    return;
+
+  // step the lfo phase
+  phase_ += rate_;
+  // sine is i16, depth u8 -> 23 bit value, shifted down by 10 bits gives a
+  // range of 13 bits (~±0.26 -> four semitones)
+  current_ = FP_ONE + ((sine_i16_interpolated_64(phase_) * depth_) >> 10);
+};
+
+void Vibrato::UpdateSRP(struct RUParams &rup) {
+  if (!enabled_)
+    return;
+  rup.speedOffset_ = fp_mul(rup.speedOffset_, current_);
+}

sources/Application/Instruments/SRPUpdaters.h

@@ -113,14 +113,19 @@ class Panner : public I_SRPUpdater {
   fixed speed_;
 };
 
-/*class Vibrato: public I_SRPUpdater {
+class Vibrato : public I_SRPUpdater {
 public:
-        Vibrato() {} ;
-        virtual ~Vibrato() {} ;
-        void SetData() ;
-        virtual void Trigger(bool tableTick) ;
-        virtual void UpdateSRP(struct RUParams &rup) ;
+  Vibrato(){};
+  virtual ~Vibrato(){};
+  void SetData(uint8_t rate, uint8_t depth);
+  virtual void Trigger(bool tableTick);
+  virtual void UpdateSRP(struct RUParams &rup);
+
 private:
-} ;
-*/
+  fixed current_;
+  uint8_t depth_;
+  uint16_t phase_;
+  uint16_t rate_;
+};
+
 #endif

sources/Application/Instruments/SampleInstrument.cpp

@@ -10,10 +10,10 @@
 #include "SampleInstrument.h"
 #include "Application/Instruments/Filters.h"
 #include "Application/Model/Table.h"
-#include "Application/Player/PlayerMixer.h" // For MIX_BUFFER_SIZE.. kick out pls
 #include "Application/Player/SyncMaster.h"
 #include "Application/Utils/fixed.h"
 #include "CommandList.h"
+#include "Foundation/Constants/SineTable.h"
 #include "SamplePool.h"
 #include "SampleVariable.h"
 #include "Services/Audio/Audio.h"
@@ -1433,6 +1433,19 @@ void SampleInstrument::ProcessCommand(int channel, FourCC cc, ushort value) {
     if (crush > 0)
       rp->crush_ = crush;
   }
+
+  case FourCC::InstrumentCommandVibrato: {
+    uint8_t rate = value >> 8;
+    uint8_t depth = value & 0xFF;
+    // setup the vibrato
+    rp->vibrato_.SetData(rate, depth);
+    if (!rp->vibrato_.Enabled()) {
+      // enable and add to active updaters
+      rp->vibrato_.Enable();
+      rp->activeUpdaters_.push_back(&rp->vibrato_);
+    }
+  } break;
+
   default:
     break;
   };

sources/Application/Instruments/SampleRenderingParams.h

@@ -70,6 +70,7 @@ struct renderParams {
   LogSpeedRamp legato_;
   LogSpeedRamp pfin_;
   Arp arp_;
+  Vibrato vibrato_;
 
   bool couldClick_;
 

sources/Application/Utils/HelpLegend.h

@@ -111,6 +111,10 @@ static char **getHelpLegend(FourCC command) {
     result[0] = (char *)("MIDI Chord:abcd");
     result[1] = (char *)("send rel notes:+a,+b,+c,+d");
     break;
+  case FourCC::InstrumentCommandVibrato:
+    result[0] = (char *)("VIBrato:aabb");
+    result[1] = (char *)("rate aa, depth bb");
+    break;
   default:
     result[0] = result[1] = (char *)("");
     break;

sources/Foundation/Constants/SineTable.h

@@ -0,0 +1,36 @@
+/*
+ * SPDX-License-Identifier: BSD-3-Clause
+ *
+ * Copyright (c) 2026 xiphonics, inc.
+ *
+ * This file is part of the picoTracker firmware
+ */
+
+#pragma once
+
+// 64-step (+ sentinel) sine wave lookup table (full cycle)
+// sin(2 * pi * index / 64) * 32767
+constexpr int16_t sine_i16_64[65] = {
+    0,      3212,   6393,   9512,   12539,  15446,  18204,  20787,  23170,
+    25329,  27245,  28898,  30273,  31356,  32137,  32609,  32767,  32609,
+    32137,  31356,  30273,  28898,  27245,  25329,  23170,  20787,  18204,
+    15446,  12539,  9512,   6393,   3212,   0,      -3212,  -6393,  -9512,
+    -12539, -15446, -18204, -20787, -23170, -25329, -27245, -28898, -30273,
+    -31356, -32137, -32609, -32767, -32609, -32137, -31356, -30273, -28898,
+    -27245, -25329, -23170, -20787, -18204, -15446, -12539, -9512,  -6393,
+    -3212,  0,
+};
+
+// 16bit interpolation for 64-step sine table
+static inline int32_t sine_i16_interpolated_64(uint16_t phase) {
+  // index into the table (top 6 bits) and fractional part (lower 10 bits)
+  uint8_t index = phase >> 10;   // 0..63
+  int32_t frac = phase & 0x03FF; // 0..1023
+
+  // fetch table values
+  int32_t a = sine_i16_64[index];
+  int32_t b = sine_i16_64[index + 1];
+
+  // a + ((b - a) * frac) / 1024
+  return a + (((b - a) * frac) >> 10);
+}

sources/Foundation/Types/Types.h

@@ -45,6 +45,7 @@ struct FourCC {
     InstrumentCommandVolume = 69,              // VOLM
     InstrumentCommandNone = 45,                // ----
     InstrumentCommandMidiChord = 143,
+    InstrumentCommandVibrato = 73,
 
     SampleInstrumentCrushVolume = 3,
     SampleInstrumentVolume = 19,
@@ -292,6 +293,7 @@ struct FourCC {
   ETL_ENUM_TYPE(InstrumentCommandDelay, "DLY")
   ETL_ENUM_TYPE(InstrumentCommandInstrumentRetrigger, "IRT")
   ETL_ENUM_TYPE(InstrumentCommandMidiChord, "MCH")
+  ETL_ENUM_TYPE(InstrumentCommandVibrato, "VIB")
 
   ETL_ENUM_TYPE(VarLineOut, "LINEOUT")
   ETL_ENUM_TYPE(VarMidiDevice, "MIDIDEVICE")