Variable list -> array#1402
Open
n1LS wants to merge 1 commit intoxiphonics:masterfrom
Open
Conversation
Contributor
n1LS
commented
Apr 8, 2026
n1LS
commented
- saves 8.880 Bytes FLASH
- saves 6.424 Bytes RAM
This was referenced Apr 8, 2026
Closed
maks
requested changes
Apr 9, 2026
Collaborator
maks
left a comment
maks
left a comment
There was a problem hiding this comment.
@n1LS there are a number of places where valid data checks (eg. non null) are missing. Please fix this critical issue as I reproduced at least one resulting hardfault from it.
This includes SaveContent in I_Instrument, Clone and many others.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.