Merged
Conversation
commit-id:03f0eba1
cdleary
approved these changes
Jul 30, 2025
| }) | ||
| } | ||
|
|
||
| fn fresh_symbol(&mut self, name: &str) -> io::Result<String> { |
Contributor
There was a problem hiding this comment.
io::Error seems a bit strange for this, I think this makes sense to be just Result instead of io::Result and then we can use thiserror to make an appropriate error type at the trait level? Doesn't have to be this PR though
Collaborator
Author
There was a problem hiding this comment.
Ah good idea. I think this was designed when I was starting with easy-smt crate, which using io::Result. Yes we should generalize it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: