[vastly] Add support for casts and module parameters.

[meheff]

No description provided.

[chatgpt-codex-connector]

💡 Codex Review

xlsynth-crate/xlsynth-vastly/src/combo_eval.rs

Line 677 in b1ea128

let mut env = init_function_env(f, args);

Carry module params into combo function environments

eval_combo now seeds env with m.consts, but function calls rebuild a fresh env via init_function_env(f, args) that only contains args/locals/return. As a result, a helper function that references a module parameter (e.g. Mask) fails with unknown identifier during normal eval and coverage eval, breaking parameterized modules that use functions.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[meheff]

💡 Codex Review

xlsynth-crate/xlsynth-vastly/src/combo_eval.rs

Line 677 in b1ea128

let mut env = init_function_env(f, args);

Carry module params into combo function environments
eval_combo now seeds env with m.consts, but function calls rebuild a fresh env via init_function_env(f, args) that only contains args/locals/return. As a result, a helper function that references a module parameter (e.g. Mask) fails with unknown identifier during normal eval and coverage eval, breaking parameterized modules that use functions.

ℹ️ About Codex in GitHub

Fixed and added test.