Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix identation textarea (related to issue #117) #118

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

benjamin-dreux
Copy link

@benjamin-dreux benjamin-dreux commented Nov 14, 2024

For the moment, add a failing test for view with indentation that do not indent for textarea element.
I intent to propose a fix also for #117 with this same PR.

But let's agree on the test required first

@benjamin-dreux benjamin-dreux changed the title Fix identation textarea Fix identation textarea (related to issue #117) Nov 14, 2024
@benjamin-dreux
Copy link
Author

After playing with
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea I also noticed that in a textarea the first line return is not taken into consideration, but the one before the closing tag is.

So we ended with something that could look weird but is indented as much as possible as long as it does not affect the content of the textarea itself.

I'm not quite certain if this introduce regression on text inside an element diffrent from textarea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant