FEAT: support #replicas > #GPU #4143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OliverBryant
force-pushed
the
FEAT/multi-replica
branch
from
0f618a7 to
d482119
Compare
qinxuye
changed the title
OliverBryant
force-pushed
the
FEAT/multi-replica
branch
from
9afaf2c to
b6ae14f
Compare
qinxuye
reviewed
Nov 21, 2025
OliverBryant
force-pushed
the
FEAT/multi-replica
branch
from
cd87ea8 to
5b5901b
Compare
OliverBryant
force-pushed
the
FEAT/multi-replica
branch
from
6274208 to
3a2555b
Compare
qinxuye
reviewed
Dec 10, 2025
OliverBryant
force-pushed
the
FEAT/multi-replica
branch
from
3802f55 to
079c3a4
Compare
OliverBryant
force-pushed
the
FEAT/multi-replica
branch
from
1f73f95 to
48ad42c
Compare
qinxuye
reviewed
Dec 12, 2025
| } | ||
| return gpu_info or None | ||
|
|
||
| async def _install_strategy_on_worker(self, model_uid: str, worker_ref) -> None: |
Contributor
There was a problem hiding this comment.
Why do we need to install strategy on worker.
I don't think we need worker for any launch strategy, the allocation could be run on supervisor only, when launched, the worker and gpu idxes for a replica is confirmed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #4104