Skip to content

Conversation

thekid
Copy link
Member

@thekid thekid commented Feb 3, 2023

See xp-framework/rfc#344 and https://github.com/xp-framework/test. Mostly migrated automatically, needed a small fix for imports from global namespace (use Traversable;), using patterns inside #[Expect] which previously supported substring matches and adjustments to not use fn()-syntax inside #[Condition].

Metrics

Before

Tests:       902 passed, 4 skipped
Memory used: 12261.99 kB (12314.85 kB peak)
Time taken:  0.231 seconds

After

Test cases:  902 succeeded, 4 skipped
Memory used: 11046.30 kB (11100.43 kB peak)
Time taken:  0.248 seconds (1.403 seconds overall)

@thekid thekid merged commit 90fe502 into master Feb 11, 2023
@thekid thekid deleted the refactor/migrate-testing branch February 11, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

1 participant