Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Result::$stack #177

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Remove Result::$stack #177

merged 1 commit into from
Oct 3, 2023

Conversation

thekid
Copy link
Member

@thekid thekid commented Oct 3, 2023

Use local variables for backing up and restoring locals. There is no usecase where we need to access locals two or more levels above the current locals, which is what we would need the stack for.

Slight performance / memory usage improvements

Before:

Test cases:  952 succeeded, 8 skipped
Memory used: 11839.18 kB (11893.41 kB peak)
Time taken:  0.155 seconds (0.230 seconds overall)

After:

Test cases:  952 succeeded, 8 skipped
Memory used: 11832.96 kB (11887.19 kB peak)
Time taken:  0.143 seconds (0.210 seconds overall)

@thekid thekid merged commit 487a9d5 into master Oct 3, 2023
@thekid thekid deleted the refactor/remove-stack branch October 3, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant