Xqemu messages consistency #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please consider squishing the commits. Apart from that, your changes look good to me. 👍 |
Member
|
Please make the commit titles shorter so they don't wrap into the commit description. I'd like a native speaker do the review. |
Significantbits
force-pushed
the
xqemu_messages_consistency
branch
from
ac38a47 to
8b7094d
Compare
Significantbits
force-pushed
the
xqemu_messages_consistency
branch
from
8b7094d to
ee63e6f
Compare
Author
|
Okay, I've squashed the commits and made the message shorter. Let me know if there is anything else I need to do. |
Contributor
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to close #62. The result of this change can be viewed in the image below.