Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: social tags checker #39

Merged
merged 2 commits into from
Jun 11, 2024
Merged

RF: social tags checker #39

merged 2 commits into from
Jun 11, 2024

Conversation

kynrai
Copy link
Collaborator

@kynrai kynrai commented Jun 11, 2024

Part of work to parallelise all tests

  • remove gock from social tags test as it uses global scope.
  • move social tags to checks as part of larger refactor
  • remove table tests as fileds were being used as part of logic, complex and unmaintainable in the long run

@kynrai kynrai requested a review from Lissy93 as a code owner June 11, 2024 00:25
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 74.07407% with 14 lines in your changes missing coverage. Please review.

Flag Coverage Δ
unittests 49.16% <74.07%> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
handlers/social_tags.go 69.23% <66.66%> (-17.44%) ⬇️
server/server.go 0.00% <0.00%> (ø)
checks/checks.go 0.00% <0.00%> (ø)
checks/social_tags.go 80.85% <80.85%> (ø)

... and 1 file with indirect coverage changes

@Lissy93 Lissy93 merged commit b00c48a into main Jun 11, 2024
3 checks passed
@Lissy93 Lissy93 deleted the rf/social_tags_checker branch June 11, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants