Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RF: headers #49

Merged
merged 2 commits into from
Jun 14, 2024
Merged

RF: headers #49

merged 2 commits into from
Jun 14, 2024

Conversation

syywu
Copy link
Contributor

@syywu syywu commented Jun 14, 2024

  • Refactored and moved headers logic to checks
  • Removed valid url test as the same logic is tested in checks/headers_test.go

@syywu syywu requested a review from Lissy93 as a code owner June 14, 2024 14:06
@syywu syywu changed the title RF: Headers RF: headers Jun 14, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Flag Coverage Δ
unittests 52.64% <68.42%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
handlers/headers.go 100.00% <100.00%> (+16.66%) ⬆️
checks/checks.go 0.00% <0.00%> (ø)
server/server.go 0.00% <0.00%> (ø)
checks/headers.go 73.33% <73.33%> (ø)

Lissy93
Lissy93 approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I really like this - thanks for the contribution 💜

@Lissy93 Lissy93 merged commit 4fc4787 into xray-web:main Jun 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lissy93 Lissy93 Lissy93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syywu @Lissy93