Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XEP-0388: add missing elements to XML Schema #1333

Merged
merged 3 commits into from
Mar 25, 2024
Merged

XEP-0388: add missing elements to XML Schema #1333

merged 3 commits into from
Mar 25, 2024

Conversation

iNPUTmice
Copy link
Contributor

@iNPUTmice iNPUTmice commented Mar 20, 2024 •
edited
Loading

@iNPUTmice iNPUTmice added Needs Version Block The change requires a version block, and this is to be done by Editors at merge time. Needs Council The affected XEP has the Council as Approving Body and it needs to decide on the change. labels Mar 20, 2024
@iNPUTmice iNPUTmice force-pushed the xep-0388-fix-schema branch from 3c39032 to aeb2848 Compare March 20, 2024 13:23
@iNPUTmice iNPUTmice changed the title XEP-0388: add missing elements XEP-0388: add missing elements to XML Schema Mar 20, 2024
@iNPUTmice iNPUTmice requested a review from mwild1 March 20, 2024 16:39
@iNPUTmice iNPUTmice force-pushed the xep-0388-fix-schema branch from aeb2848 to d9d4f81 Compare March 21, 2024 15:17
@iNPUTmice iNPUTmice added Needs Author The XEP is experimental and the PR was not made by the author. The author needs to acknowledge it. and removed Needs Council The affected XEP has the Council as Approving Body and it needs to decide on the change. Needs Version Block The change requires a version block, and this is to be done by Editors at merge time. labels Mar 22, 2024
@iNPUTmice
Copy link
Contributor Author

@mwild1 or @tmolitor-stud-tu please review

tmolitor-stud-tu
tmolitor-stud-tu suggested changes Mar 24, 2024
View reviewed changes
Copy link
Contributor

@tmolitor-stud-tu tmolitor-stud-tu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my suggested changes

xep-0388.xml Outdated Show resolved Hide resolved
@iNPUTmice @tmolitor-stud-tu
Update xep-0388.xml
28a66a9 
Co-authored-by: Thilo Molitor <[email protected]>
@iNPUTmice iNPUTmice merged commit 3ce1a35 into xsf:master Mar 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmolitor-stud-tu tmolitor-stud-tu tmolitor-stud-tu approved these changes

@mwild1 mwild1 Awaiting requested review from mwild1

Assignees
No one assigned
Labels
Needs Author The XEP is experimental and the PR was not made by the author. The author needs to acknowledge it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iNPUTmice @tmolitor-stud-tu