Avoid generating malformed UTF-8 and replacement characters by inter… #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks PR. However tests are failed on Perl 5.20 or higher versions. |
|
Looks like with Perl 5.20 and higher the semantics of one-byte hex notated characters changed. Now covering that with the tests |
|
Nicholas Clark provided an improved version of the patch. Travis CI checks pass. |
|
Could you squash commits ? |
…s malformed UTF-8 on output" (nc) Now using U8 casts - *(d++) = UTF8_EIGHT_BIT_HI(c); - *(d++) = UTF8_EIGHT_BIT_LO(c); + *(d++) = UTF8_EIGHT_BIT_HI((U8) c); + *(d++) = UTF8_EIGHT_BIT_LO((U8) c); Minor POD improvement
|
Squashed |
Merged
|
@pepl Thanks great work. I have cherry-picked your commit. 👍 |
skaji
added a commit
that referenced
this pull request
Nov 30, 2017
Changelog diff is:
diff --git a/Changes b/Changes
index 6160d1e7..605d1077 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,15 @@
Revision history for Perl extension Text::Xslate
+{{$NEXT}}
+
+v3.5.0 2017-11-30T15:57:50Z
+ - Migrate to using minil (#179)
+ - Improve perl 5.8 support (#182)
+ - Use version->declare() to declare $VERSION (#182)
+ - Make `prove -br t` work with dot-not-in-INC perls (#184)
+ - Run tests against both XS and pureperl (#185)
+ - Fix typo (anirvan #181)
+
3.4.0 2017-01-20 15:00:00+0900
- Fix tied hash issue(#173)
- Fix encoding issue(#160)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…polating the variable as-is if it is not a valid UTF-8 sequence (nc), Github issue #88