Skip to content

Remove out-of-line definition of constexpr static data members #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove out-of-line definition of constexpr static data members #1127

wants to merge 1 commit into from

Conversation

r-barnes
Copy link

Fixes, eg

xsimd/types/xsimd_batch.hpp:284:45: error: out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated [-Werror,-Wdeprecated-redundant-constexpr-static-def]
  284 |     constexpr std::size_t batch_bool<T, A>::size;
      |                                             ^

@r-barnes
Remove out-of-line definition of constexpr static data members
9c6d43f 
Fixes, eg
```
xsimd/types/xsimd_batch.hpp:284:45: error: out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated [-Werror,-Wdeprecated-redundant-constexpr-static-def]
  284 |     constexpr std::size_t batch_bool<T, A>::size;
      |                                             ^
```
@serge-sans-paille
Copy link
Contributor

Thanks for the patch! Can you rebase on master? We updated windows config recently...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-barnes @serge-sans-paille