Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose key helpers on the API for addons #5292

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Prev Previous commit
Next Next commit
remove vs imports from shared
jerch committed Jan 10, 2025
commit 41d1ca1907316f1472f5ae27e5d7f7a398e542bc
5 changes: 2 additions & 3 deletions src/browser/public/Terminal.ts
Original file line number Diff line number Diff line change
@@ -280,10 +280,9 @@ export class Terminal extends Disposable implements ITerminalApi {
* so they can be used on addon ctors already.
*/
export {
DisposableStore as disposableStoreCtor,
toDisposable,
Emitter as emitterCtor,
DisposableAddon,
EmitterAddon,
DisposableEmitterAddon
} from 'shared/shared';
export { DisposableStore as disposableStoreCtor, toDisposable } from 'vs/base/common/lifecycle';
export { Emitter as emitterCtor } from 'vs/base/common/event';
2 changes: 0 additions & 2 deletions src/shared/shared.ts
Original file line number Diff line number Diff line change
@@ -5,8 +5,6 @@

import { IDisposable, IDisposableStore, DisposableStoreCtorType, EmitterCtorType } from '@xterm/xterm';

export { DisposableStore, toDisposable } from 'vs/base/common/lifecycle';
export { Emitter } from 'vs/base/common/event';

export class DisposableAddon implements IDisposable {
protected readonly _store: IDisposableStore;