Skip to content

feat(addon-fit): fit to specific dimensions #5316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(addon-fit): fit to specific dimensions #5316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions addons/addon-fit/src/FitAddon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ export class FitAddon implements ITerminalAddon , IFitApi {

public dispose(): void {}

public fit(): void {
const dims = this.proposeDimensions();
public fit(dims?: ITerminalDimensions): void {
dims = dims ?? this.proposeDimensions();
if (!dims || !this._terminal || isNaN(dims.cols) || isNaN(dims.rows)) {
return;
}
Expand Down
3 changes: 2 additions & 1 deletion addons/addon-fit/typings/addon-fit.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@ declare module '@xterm/addon-fit' {

/**
* Resizes the terminal to the dimensions of its containing element.
* @param dims The dimensions to fit the terminal into.
*/
public fit(): void;
public fit(dims?: ITerminalDimensions): void;

/**
* Gets the proposed dimensions that will be used for a fit.
Expand Down