xvrh · xvrh · Oct 23, 2020 · Oct 23, 2020
diff --git a/.github/workflows/analyze-and-test.yaml → .github/workflows/analyze.yaml b/.github/workflows/analyze-and-test.yaml → .github/workflows/analyze.yaml
@@ -11,7 +11,7 @@ jobs:
     strategy:
       matrix:
         flutter: ['stable']
-    runs-on: macos-latest
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
       - uses: subosito/flutter-action@v1
@@ -22,9 +22,6 @@ jobs:
       - run: flutter pub get
         working-directory: example
       - run: flutter analyze
-      - run: flutter test test # https://github.com/flutter/flutter/issues/20907
-      - run: flutter test test
-        working-directory: example
       - run: flutter pub run tool/prepare_submit.dart
       - name: "check for uncommitted changes"
         run: |

diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -0,0 +1,17 @@
+name: Lottie Flutter
+on:
+  pull_request:
+  push:
+    branches:
+      - master
+
+jobs:
+  test:
+    name: Run all tests
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Run tests
+        uses: docker://cirrusci/flutter:1.22.1
+        with:
+          args: sh run_tests.sh
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -0,0 +1,7 @@
+
+## Run the Golden tests
+Run and update the golden tests requires Docker installed.
+
+```shell script
+sh update_goldens.sh
+```
diff --git a/example/pubspec.lock b/example/pubspec.lock
@@ -7,14 +7,14 @@ packages:
       name: archive
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.0.13"
+    version: "2.0.11"
   args:
     dependency: transitive
     description:
       name: args
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.6.0"
+    version: "1.5.2"
   async:
     dependency: transitive
     description:
@@ -70,7 +70,7 @@ packages:
       name: crypto
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.1.5"
+    version: "2.1.3"
   fake_async:
     dependency: transitive
     description:
@@ -213,7 +213,7 @@ packages:
       name: pedantic
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.9.2"
+    version: "1.8.0+1"
   platform:
     dependency: transitive
     description:
@@ -309,7 +309,7 @@ packages:
       name: xdg_directories
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.1.2"
+    version: "0.1.0"
 sdks:
   dart: ">=2.10.0-110 <2.11.0"
   flutter: ">=1.12.13+hotfix.5 <2.0.0"
diff --git a/example/test/dynamic_properties_test.dart b/example/test/dynamic_properties_test.dart
@@ -22,6 +22,9 @@ void main() {
         .replaceAll(' ', '_');
 
     testWidgets(description, (tester) async {
+      tester.binding.window.physicalSizeTestValue = Size(500, 400);
+      tester.binding.window.devicePixelRatioTestValue = 1.0;
+
       var animation =
           AnimationController(vsync: tester, duration: composition.duration);
       if (progress != null) {

diff --git a/example/test/dynamic_text_test.dart b/example/test/dynamic_text_test.dart
@@ -6,6 +6,9 @@ import 'package:lottie/lottie.dart';
 
 void main() {
   testWidgets('Dynamic test', (tester) async {
+    tester.binding.window.physicalSizeTestValue = Size(500, 400);
+    tester.binding.window.devicePixelRatioTestValue = 1.0;
+
     var composition = await LottieComposition.fromBytes(
         File('assets/Tests/DynamicText.json').readAsBytesSync());
 

diff --git a/example/test/goldens/all/14595-thumbs-up.png b/example/test/goldens/all/14595-thumbs-up.png
diff --git a/example/test/goldens/all/Logo/logosmall.png b/example/test/goldens/all/Logo/logosmall.png
diff --git a/example/test/goldens/all/Mobilo/f.png b/example/test/goldens/all/Mobilo/f.png
diff --git a/example/test/goldens/all/Mobilo/g.png b/example/test/goldens/all/Mobilo/g.png
diff --git a/example/test/goldens/all/Tests/dynamictext.png b/example/test/goldens/all/Tests/dynamictext.png
diff --git a/...est/goldens/all/Tests/font_text_justification_translate_scale_rotation_test.png b/...est/goldens/all/Tests/font_text_justification_translate_scale_rotation_test.png
diff --git a/example/test/goldens/all/hamburgerarrow.png b/example/test/goldens/all/hamburgerarrow.png
diff --git a/example/test/goldens/all/lottiefiles/atm_link.png b/example/test/goldens/all/lottiefiles/atm_link.png
diff --git a/example/test/goldens/all/lottiefiles/im_thirsty.png b/example/test/goldens/all/lottiefiles/im_thirsty.png
diff --git a/example/test/goldens/all/lottiefiles/lottie_logo_1.png b/example/test/goldens/all/lottiefiles/lottie_logo_1.png
diff --git a/example/test/goldens/all/lottiefiles/moving_eye.png b/example/test/goldens/all/lottiefiles/moving_eye.png
diff --git a/example/test/goldens/all/lottiefiles/passport.png b/example/test/goldens/all/lottiefiles/passport.png
diff --git a/example/test/goldens/all/lottiefiles/personal_character.png b/example/test/goldens/all/lottiefiles/personal_character.png
diff --git a/example/test/goldens/all/lottiefiles/progress_bar.png b/example/test/goldens/all/lottiefiles/progress_bar.png
diff --git a/example/test/goldens/all/lottiefiles/star 2.png b/example/test/goldens/all/lottiefiles/star 2.png
diff --git a/example/test/goldens/all/lottiefiles/streetbymorning.png b/example/test/goldens/all/lottiefiles/streetbymorning.png
diff --git a/example/test/goldens/all/lottiefiles/tractor.png b/example/test/goldens/all/lottiefiles/tractor.png
diff --git a/example/test/goldens/all/lottielogo1.png b/example/test/goldens/all/lottielogo1.png
diff --git a/example/test/goldens/dynamic/color_filter.png b/example/test/goldens/dynamic/color_filter.png
diff --git a/example/test/goldens/dynamic/ellipse_position.png b/example/test/goldens/dynamic/ellipse_position.png
diff --git a/example/test/goldens/dynamic/ellipse_size.png b/example/test/goldens/dynamic/ellipse_size.png
diff --git a/example/test/goldens/dynamic/fill_color_green.png b/example/test/goldens/dynamic/fill_color_green.png
diff --git a/example/test/goldens/dynamic/fill_color_yellow.png b/example/test/goldens/dynamic/fill_color_yellow.png
diff --git a/example/test/goldens/dynamic/fill_opacity.png b/example/test/goldens/dynamic/fill_opacity.png
diff --git a/example/test/goldens/dynamic/null_color_filter.png b/example/test/goldens/dynamic/null_color_filter.png
diff --git a/example/test/goldens/dynamic/opacity_interpolation_00.png b/example/test/goldens/dynamic/opacity_interpolation_00.png
diff --git a/example/test/goldens/dynamic/opacity_interpolation_05.png b/example/test/goldens/dynamic/opacity_interpolation_05.png
diff --git a/example/test/goldens/dynamic/opacity_interpolation_10.png b/example/test/goldens/dynamic/opacity_interpolation_10.png
diff --git a/example/test/goldens/dynamic/polygon_points.png b/example/test/goldens/dynamic/polygon_points.png
diff --git a/example/test/goldens/dynamic/polygon_position.png b/example/test/goldens/dynamic/polygon_position.png
diff --git a/example/test/goldens/dynamic/polygon_radius.png b/example/test/goldens/dynamic/polygon_radius.png
diff --git a/example/test/goldens/dynamic/polygon_rotation.png b/example/test/goldens/dynamic/polygon_rotation.png
diff --git a/example/test/goldens/dynamic/polygon_roundedness.png b/example/test/goldens/dynamic/polygon_roundedness.png
diff --git a/example/test/goldens/dynamic/rectangle_corner_roundedness.png b/example/test/goldens/dynamic/rectangle_corner_roundedness.png
diff --git a/example/test/goldens/dynamic/rectangle_position.png b/example/test/goldens/dynamic/rectangle_position.png
diff --git a/example/test/goldens/dynamic/rectangle_size.png b/example/test/goldens/dynamic/rectangle_size.png
diff --git a/example/test/goldens/dynamic/repeater_transform_end_opacity.png b/example/test/goldens/dynamic/repeater_transform_end_opacity.png
diff --git a/example/test/goldens/dynamic/repeater_transform_position.png b/example/test/goldens/dynamic/repeater_transform_position.png
diff --git a/example/test/goldens/dynamic/repeater_transform_rotation.png b/example/test/goldens/dynamic/repeater_transform_rotation.png
diff --git a/example/test/goldens/dynamic/repeater_transform_scale.png b/example/test/goldens/dynamic/repeater_transform_scale.png
diff --git a/example/test/goldens/dynamic/repeater_transform_start_opacity.png b/example/test/goldens/dynamic/repeater_transform_start_opacity.png
diff --git a/example/test/goldens/dynamic/star_inner_radius.png b/example/test/goldens/dynamic/star_inner_radius.png
diff --git a/example/test/goldens/dynamic/star_inner_roundedness.png b/example/test/goldens/dynamic/star_inner_roundedness.png
diff --git a/example/test/goldens/dynamic/star_outer_radius.png b/example/test/goldens/dynamic/star_outer_radius.png
diff --git a/example/test/goldens/dynamic/star_outer_roundedness.png b/example/test/goldens/dynamic/star_outer_roundedness.png
diff --git a/example/test/goldens/dynamic/star_points.png b/example/test/goldens/dynamic/star_points.png
diff --git a/example/test/goldens/dynamic/star_position.png b/example/test/goldens/dynamic/star_position.png
diff --git a/example/test/goldens/dynamic/star_rotation.png b/example/test/goldens/dynamic/star_rotation.png
diff --git a/example/test/goldens/dynamic/stroke_color.png b/example/test/goldens/dynamic/stroke_color.png
diff --git a/example/test/goldens/dynamic/stroke_opacity.png b/example/test/goldens/dynamic/stroke_opacity.png
diff --git a/example/test/goldens/dynamic/stroke_width.png b/example/test/goldens/dynamic/stroke_width.png
diff --git a/example/test/goldens/dynamic/time_remapping.png b/example/test/goldens/dynamic/time_remapping.png
diff --git a/example/test/goldens/dynamic/transform_anchor_point.png b/example/test/goldens/dynamic/transform_anchor_point.png
diff --git a/example/test/goldens/dynamic/transform_opacity.png b/example/test/goldens/dynamic/transform_opacity.png
diff --git a/example/test/goldens/dynamic/transform_position.png b/example/test/goldens/dynamic/transform_position.png
diff --git a/example/test/goldens/dynamic/transform_position_relative.png b/example/test/goldens/dynamic/transform_position_relative.png
diff --git a/example/test/goldens/dynamic/transform_rotation.png b/example/test/goldens/dynamic/transform_rotation.png
diff --git a/example/test/goldens/dynamic/transform_scale.png b/example/test/goldens/dynamic/transform_scale.png
diff --git a/example/test/goldens/dynamic_text.png b/example/test/goldens/dynamic_text.png
diff --git a/example/test/goldens/dynamic_without_delegate.png b/example/test/goldens/dynamic_without_delegate.png
diff --git a/example/test/goldens/gradients/linear_gradient_fill.png b/example/test/goldens/gradients/linear_gradient_fill.png
diff --git a/example/test/goldens/gradients/linear_gradient_stroke.png b/example/test/goldens/gradients/linear_gradient_stroke.png
diff --git a/example/test/goldens/gradients/opacity_linear_gradient_fill.png b/example/test/goldens/gradients/opacity_linear_gradient_fill.png
diff --git a/example/test/goldens/gradients/radial_gradient_fill.png b/example/test/goldens/gradients/radial_gradient_fill.png
diff --git a/example/test/goldens/gradients/radial_gradient_stroke.png b/example/test/goldens/gradients/radial_gradient_stroke.png
diff --git a/example/test/gradient_test.dart b/example/test/gradient_test.dart
@@ -7,6 +7,9 @@ import 'package:lottie/lottie.dart';
 void main() {
   void testGradient(String name, ValueDelegate valueDelegate) {
     testWidgets(name, (tester) async {
+      tester.binding.window.physicalSizeTestValue = Size(500, 400);
+      tester.binding.window.devicePixelRatioTestValue = 1.0;
+
       var composition = await LottieComposition.fromBytes(
           File('assets/Tests/DynamicGradient.json').readAsBytesSync());
 

diff --git a/pubspec.lock b/pubspec.lock
@@ -7,28 +7,28 @@ packages:
       name: _fe_analyzer_shared
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "11.0.0"
+    version: "7.0.0"
   analyzer:
     dependency: "direct dev"
     description:
       name: analyzer
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.40.4"
+    version: "0.39.17"
   archive:
     dependency: "direct main"
     description:
       name: archive
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.0.13"
+    version: "2.0.11"
   args:
     dependency: transitive
     description:
       name: args
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.6.0"
+    version: "1.5.2"
   async:
     dependency: transitive
     description:
@@ -43,27 +43,6 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "2.1.0-nullsafety.1"
-  build:
-    dependency: transitive
-    description:
-      name: build
-      url: "https://pub.dartlang.org"
-    source: hosted
-    version: "1.5.0"
-  built_collection:
-    dependency: transitive
-    description:
-      name: built_collection
-      url: "https://pub.dartlang.org"
-    source: hosted
-    version: "4.3.2"
-  built_value:
-    dependency: transitive
-    description:
-      name: built_value
-      url: "https://pub.dartlang.org"
-    source: hosted
-    version: "7.1.0"
   characters:
     dependency: "direct main"
     description:
@@ -92,13 +71,6 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "1.1.0-nullsafety.1"
-  code_builder:
-    dependency: transitive
-    description:
-      name: code_builder
-      url: "https://pub.dartlang.org"
-    source: hosted
-    version: "3.5.0"
   collection:
     dependency: "direct main"
     description:
@@ -119,28 +91,28 @@ packages:
       name: crypto
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.1.5"
+    version: "2.1.3"
+  csslib:
+    dependency: transitive
+    description:
+      name: csslib
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "0.16.2"
   dart_style:
     dependency: "direct dev"
     description:
       name: dart_style
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.3.8"
+    version: "1.3.6"
   fake_async:
     dependency: transitive
     description:
       name: fake_async
       url: "https://pub.dartlang.org"
     source: hosted
     version: "1.2.0-nullsafety.1"
-  fixnum:
-    dependency: transitive
-    description:
-      name: fixnum
-      url: "https://pub.dartlang.org"
-    source: hosted
-    version: "0.10.11"
   flutter:
     dependency: "direct main"
     description: flutter
@@ -158,6 +130,13 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "1.2.0"
+  html:
+    dependency: transitive
+    description:
+      name: html
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "0.14.0+4"
   js:
     dependency: transitive
     description:
@@ -192,7 +171,7 @@ packages:
       name: mockito
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "4.1.3"
+    version: "4.1.1"
   node_interop:
     dependency: transitive
     description:
@@ -227,33 +206,19 @@ packages:
       name: pedantic
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.9.2"
+    version: "1.8.0+1"
   pub_semver:
     dependency: transitive
     description:
       name: pub_semver
       url: "https://pub.dartlang.org"
     source: hosted
     version: "1.4.4"
-  quiver:
-    dependency: transitive
-    description:
-      name: quiver
-      url: "https://pub.dartlang.org"
-    source: hosted
-    version: "2.1.3"
   sky_engine:
     dependency: transitive
     description: flutter
     source: sdk
     version: "0.0.99"
-  source_gen:
-    dependency: transitive
-    description:
-      name: source_gen
-      url: "https://pub.dartlang.org"
-    source: hosted
-    version: "0.9.7+1"
   source_span:
     dependency: transitive
     description:

diff --git a/run_tests.sh b/run_tests.sh
@@ -0,0 +1,2 @@
+flutter test test
+(cd example && flutter test test)
diff --git a/update_goldens.sh b/update_goldens.sh
@@ -0,0 +1 @@
+docker run --rm -it -v "${PWD}":/build --workdir /build cirrusci/flutter:1.22.1 sh update_goldens_inside_docker.sh
diff --git a/update_goldens_inside_docker.sh b/update_goldens_inside_docker.sh
@@ -0,0 +1,12 @@
+PUB_CACHE="$(mktemp -d)"
+export PUB_CACHE
+COPY_DIR="$(mktemp -d)"
+
+(cd /build && git ls-files | xargs -I '{}' cp -pR --parents '{}' "$COPY_DIR")
+cd "$COPY_DIR" || exit
+flutter test --update-goldens test
+cp -pR test/* /build/test
+
+cd example || exit
+flutter test --update-goldens test
+cp -pR test/* /build/example/test
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		flutter test test
		(cd example && flutter test test)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		docker run --rm -it -v "${PWD}":/build --workdir /build cirrusci/flutter:1.22.1 sh update_goldens_inside_docker.sh