Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dark light mode integratration done #135

Merged
merged 3 commits into from
Nov 8, 2024
Merged

dark light mode integratration done #135

merged 3 commits into from
Nov 8, 2024

Conversation

WednesdaySP
Copy link
Contributor

[Feature] to add light n dark mode toggle #89

WhatsApp.Video.2024-10-26.at.04.10.04_f7999643.mp4

@KirolosMFahem KirolosMFahem linked an issue Oct 26, 2024 that may be closed by this pull request
[Feature] to add light n dark mode toggle #89
Closed
@KirolosMFahem
Copy link
Collaborator

The pull request #135 titled "dark light mode integration done" introduces a feature to toggle between light and dark modes.

Summary of Changes:

  • lib/main.dart:

    • Added a ThemeMode notifier to track theme changes.
    • Integrated ValueListenableBuilder to switch between light and dark themes.
    • Defined _lightTheme and _darkTheme methods for theme configurations.

  • lib/pages/home_page.dart:

    • Updated UI components to use theme properties instead of fixed colors.
    • Added a theme toggle button in the AppBar.

  • lib/pages/login_page.dart:

    • Modified background and text colors to adapt to the selected theme.
    • Updated button styles to align with the theme.

@KirolosMFahem KirolosMFahem added enhancement New feature or request gssoc-ext GSSOC contribution level3 GSSOC contribution level hacktoberfest-accepted hacktoberfest contribution PR hacktoberfest hacktoberfest contribution labels Oct 26, 2024
@KirolosMFahem
Copy link
Collaborator

KirolosMFahem commented Oct 26, 2024 •
edited
Loading

as it for code it's working 😅
but as it for the UI I don't feel it
@yagnik2411

@WednesdaySP
Copy link
Contributor Author

@KirolosMFahem you can suggest the colors or changes you want I'll update them

@WednesdaySP
Copy link
Contributor Author

@KirolosMFahem @yagnik2411 can you guys please review this PR asap as not much time is left.

@KirolosMFahem
Copy link
Collaborator

this specific PR I can't merge it
@yagnik2411 must review it himself

@yagnik2411 yagnik2411 merged commit 58957fa into yagnik2411:master Nov 8, 2024
1 of 2 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

🎉🎉 Thank you for your contribution! Your PR #135 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yagnik2411 yagnik2411 yagnik2411 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request gssoc-ext GSSOC contribution hacktoberfest hacktoberfest contribution hacktoberfest-accepted hacktoberfest contribution PR level3 GSSOC contribution level
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] to add light n dark mode toggle
3 participants
@WednesdaySP @KirolosMFahem @yagnik2411