Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #96] Implemented a Summary Page post Quiz submission #99

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rishichirchi
Copy link

@rishichirchi rishichirchi commented Oct 15, 2024

This PR implements a summary page that displays the results of the quiz after submission, addressing issue #96

Summary of Changes:

  • Created a new SummaryPage that shows the number of correct answers out of the total questions.
  • Displayed the percentage of correct answers.
  • Listed each question along with its correctness (correct/incorrect).

Screenshot_20241015-235015_quiz_genius

Related Issues:

Fixes #96 .

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Boom! Your pull request just flew into the Quiz-Genius HQ. High fives all around! Our team of tech wizards will check it out and get back to you faster than you can say 'code ninja!' Thanks for leveling up the project!

@KirolosMFahem KirolosMFahem added enhancement New feature or request gssoc-ext GSSOC contribution level2 GSSOC contribution level hacktoberfest-accepted hacktoberfest contribution PR hacktoberfest hacktoberfest contribution labels Oct 15, 2024
Copy link
Collaborator

@KirolosMFahem KirolosMFahem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure in the GitHub Actions job is due to an error in the pubspec.lock file. The specific error message is:

Failed parsing lock file:
Error on line 146, column 1 of pubspec.lock: Expected ':'.
    ╷
146 │ <<<<<<< HEAD
    │ ^
    ╵
Consider deleting the file and running `flutter pub get` to recreate it.

Recommended Fix:

  1. Delete the pubspec.lock file.
  2. Run flutter pub get to recreate the pubspec.lock file.

This error is likely due to a merge conflict marker left in the pubspec.lock file. Removing and regenerating the file should resolve the issue.

@rishichirchi
Copy link
Author

@KirolosMFahem I have made the changes, can you check once?

@KirolosMFahem
Copy link
Collaborator

Summary of Pull Request #99: [Issue #96] Implemented a Summary Page post Quiz submission

This PR implements a summary page that displays the results of the quiz after submission, addressing issue #96.

Summary of Changes:

  • Created a new SummaryPage that shows the number of correct answers out of the total questions.
  • Displays the percentage of correct answers.
  • Lists each question along with its correctness (correct/incorrect).
  • Updated various files to integrate the SummaryPage into the application flow.

Related Files:

  • android/gradle/wrapper/gradle-wrapper.properties
  • lib/main.dart
  • lib/pages/home_page.dart
  • lib/pages/quiz_page.dart
  • lib/pages/summary_page.dart (new file)
  • lib/utils/my_route.dart
  • lib/utils/profile_image_service.dart

Related Issues:

@rishichirchi
Copy link
Author

@KirolosMFahem can you merge this PR please?

@KirolosMFahem
Copy link
Collaborator

@KirolosMFahem can you merge this PR please?

@yagnik2411

@yagnik2411
Copy link
Owner

but we already have previous quiz page for this

@yagnik2411
Copy link
Owner

@KirolosMFahem whats point of this to include in app instead of you can update previous quiz page.

@rishichirchi
Copy link
Author

@yagnik2411 the point of this PR is to improve the user experience of user. The current previous quiz page that can be accessed from home page has summary of all the previous quizzes but it doesn't show the analysis of the most recent one. The PR implements a feature where the user can see what questions he did right and wrong and a summary of correct questions right before moving to home screen. Then it can also be viewed by previous quiz button.

@rishichirchi
Copy link
Author

screen-20241017-094036.mp4

@rishichirchi
Copy link
Author

@KirolosMFahem @yagnik2411 any updates?

@KirolosMFahem
Copy link
Collaborator

from here @yagnik2411 is the one with the final decision

@yagnik2411
Copy link
Owner

@yagnik2411 the point of this PR is to improve the user experience of user. The current previous quiz page that can be accessed from home page has summary of all the previous quizzes but it doesn't show the analysis of the most recent one. The PR implements a feature where the user can see what questions he did right and wrong and a summary of correct questions right before moving to home screen. Then it can also be viewed by previous quiz button.

i got the point. good work on thinking of UI.

@yagnik2411
Copy link
Owner

I will test and merge asap

@yagnik2411
Copy link
Owner

@rishichirchi did you add all summary pages to all types of quizzes?

@rishichirchi
Copy link
Author

It's done for true or false type for now

@yagnik2411
Copy link
Owner

you need to do for mcq quiz

@rishichirchi
Copy link
Author

rishichirchi commented Oct 18, 2024

Surely will work on it. I didn't pull the code before doing this pr so didn't add for MCQ! It would help if you could merge it! Can be made into a new issue

@yagnik2411
Copy link
Owner

@rishichirchi okay
but first make issues and mention here.

@KirolosMFahem KirolosMFahem removed the level2 GSSOC contribution level label Oct 20, 2024
@KirolosMFahem KirolosMFahem added the level3 GSSOC contribution level label Oct 20, 2024
@rishichirchi
Copy link
Author

@yagnik2411 I have created the required issue ie issue #123 , which I will be working on next. Hope this PR gets merged now!

@yagnik2411
Copy link
Owner

lib/pages/home_page.dart
lib/pages/quiz_page.dart
@rishichirchi we have issues

@rishichirchi
Copy link
Author

@yagnik2411 will check them out

@KirolosMFahem
Copy link
Collaborator

please do sync fork to solve the conflicts

@KirolosMFahem
Copy link
Collaborator

@rishichirchi please resolve the Conflicting files ASAP for final test
once done DM me and @yagnik2411 in the comments

@rishichirchi
Copy link
Author

Yes, will do it today

@KirolosMFahem
Copy link
Collaborator

Conflicting files
lib/main.dart
lib/pages/home_page.dart
lib/pages/quiz_page.dart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc-ext GSSOC contribution hacktoberfest hacktoberfest contribution hacktoberfest-accepted hacktoberfest contribution PR level3 GSSOC contribution level
Projects
None yet
3 participants