-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue #96] Implemented a Summary Page post Quiz submission #99
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Boom! Your pull request just flew into the Quiz-Genius HQ. High fives all around! Our team of tech wizards will check it out and get back to you faster than you can say 'code ninja!' Thanks for leveling up the project!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failure in the GitHub Actions job is due to an error in the pubspec.lock
file. The specific error message is:
Failed parsing lock file:
Error on line 146, column 1 of pubspec.lock: Expected ':'.
╷
146 │ <<<<<<< HEAD
│ ^
╵
Consider deleting the file and running `flutter pub get` to recreate it.
Recommended Fix:
- Delete the
pubspec.lock
file. - Run
flutter pub get
to recreate thepubspec.lock
file.
This error is likely due to a merge conflict marker left in the pubspec.lock
file. Removing and regenerating the file should resolve the issue.
@KirolosMFahem I have made the changes, can you check once? |
Summary of Pull Request #99: [Issue #96] Implemented a Summary Page post Quiz submissionThis PR implements a summary page that displays the results of the quiz after submission, addressing issue #96. Summary of Changes:
Related Files:
Related Issues:
|
@KirolosMFahem can you merge this PR please? |
|
but we already have previous quiz page for this |
@KirolosMFahem whats point of this to include in app instead of you can update previous quiz page. |
@yagnik2411 the point of this PR is to improve the user experience of user. The current previous quiz page that can be accessed from home page has summary of all the previous quizzes but it doesn't show the analysis of the most recent one. The PR implements a feature where the user can see what questions he did right and wrong and a summary of correct questions right before moving to home screen. Then it can also be viewed by previous quiz button. |
screen-20241017-094036.mp4 |
@KirolosMFahem @yagnik2411 any updates? |
from here @yagnik2411 is the one with the final decision |
i got the point. good work on thinking of UI. |
I will test and merge asap |
@rishichirchi did you add all summary pages to all types of quizzes? |
It's done for true or false type for now |
you need to do for mcq quiz |
Surely will work on it. I didn't pull the code before doing this pr so didn't add for MCQ! It would help if you could merge it! Can be made into a new issue |
@rishichirchi okay |
@yagnik2411 I have created the required issue ie issue #123 , which I will be working on next. Hope this PR gets merged now! |
lib/pages/home_page.dart |
@yagnik2411 will check them out |
please do |
@rishichirchi please resolve the Conflicting files ASAP for final test |
Yes, will do it today |
Conflicting files |
This PR implements a summary page that displays the results of the quiz after submission, addressing issue #96
Summary of Changes:
SummaryPage
that shows the number of correct answers out of the total questions.Related Issues:
Fixes #96 .