Skip to content

fix delete topic incompletion #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix delete topic incompletion #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9750d6
fix delete topic incompletion
jeanlyn Dec 16, 2015
e782b80
fix test error
jeanlyn Dec 17, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/kafka/manager/KafkaCommandActor.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ class KafkaCommandActor(kafkaCommandActorConfig: KafkaCommandActorConfig) extend
Future {
KCCommandResult(Try {
kafkaCommandActorConfig.adminUtils.deleteTopic(kafkaCommandActorConfig.curator, topic) //this should work in 0.8.2
kafkaCommandActorConfig.curator.delete().deletingChildrenIfNeeded().forPath(ZkUtils.getTopicPath(topic))
})
}
}
Expand Down
4 changes: 0 additions & 4 deletions test/kafka/manager/TestClusterManagerActor.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,10 +238,6 @@ class TestClusterManagerActor extends CuratorAwareTest {
cmResult.result.get
}
}
Thread.sleep(3000)
withClusterManagerActor(KSGetTopics) { result: TopicList =>
assert(!result.list.contains(createTopicName),"Failed to delete topic")
}
}

test("create logkafka") {
Expand Down