-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor debug dashboard #226
Conversation
roderickhsiao
commented
Mar 28, 2019
•
edited
Loading
edited
- Refactor debug dashboard to use react component
- Use React.lazy to load component for code splitting
I looked into #23 and found it could be hard to render the debug message without adding a wrapper the the This PR still render the debug container in pure Javascript at the bottom of the page as an overlay to the Also use I could add some unit test but since we probably want to move to |
the build fails on saucelab connection, I just notice that the grunt task never successfully run before (it has syntax error) so just directly skip and return pass. I fixed the syntax error and now it seems to have difficulties connect to sauce lab. @redonkulus are you able to check if the saucelab account |
I changed to used to saucelab key I applied for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM!
As we discussed offline, I think we still have to mount debug node on root to preventing breaking styles.
Thank you for also fixing the test page and saucelab tests 🥇
@@ -170,7 +186,7 @@ module.exports = function (grunt) { | |||
main: './<%= project.functional %>/bootstrap.js' | |||
}, | |||
output: { | |||
path: './<%= project.functional %>/' | |||
path: path.resolve(process.cwd(), projectConfig.functional) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thx for fixing this, I noticed this is broken for a while
If we want to make this simpler, we can maybe do something like: in createI13nNode
and inside DebugDashboardContainer, create a new node in root and use BTW calling it |
I'll check if that is doable |
🔥 But I'd say this PR is good enough to be merged that if we want we can follow up with another PR. |
I'll cut a branch (alpha-1) and prepare for release log later today. |
3.0.0-alpha-1Features
Build Enhancement
Breaking changes
|