Add option to clear all replicas in ZK #212
Conversation
|
Maybe zookeeper logging level should be set to |
| return | ||
|
|
||
| try: | ||
| zk_client.delete(full_table_zk_path, recursive=True) |
There was a problem hiding this comment.
some time ago we already had removing metadata from zk with kazoo.delete and it's performance is awful. With system drop replica cleanup much more faster, lets use it rather zk_client.delete.
Regarding this, suggesting to keep only _clean_replica_only (mb rename to _clean_table_replica) and call it for all replicas in the table. But please make manual testing with concurrent system drop replica for single table.
There was a problem hiding this comment.
But please make manual testing with concurrent system drop replica for single table
Judging by drop replica's implementation, there is no race condition for concurrent drops, so it should work fine.
REPLICA_ONLYwas default option before