Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in comment #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix typo in comment #28

wants to merge 1 commit into from

Conversation

ivoanjo
Copy link

@ivoanjo ivoanjo commented Feb 6, 2025

Noticed this small typo :)

Noticed this small typo :)
Copy link

robot-magpie bot commented Feb 6, 2025

❌ Missing CLA from one or more contributors

Thanks for your pull request! In order for us (YANDEX LLC) to accept patches and other contributions from you,
you will have to adopt our Yandex Contributor License Agreement (the "CLA").

See CONTRIBUTING.md for more info about Yandex Contributor License Agreement.


The following contributors were found:
26ca650 Author: @ivoanjo (iv****[email protected])

(Only the first commit for a unique contributor is listed)

@ivoanjo
Copy link
Author

ivoanjo commented Feb 6, 2025

TBH I don't think it's worth my time chasing the CLA for this, so up to y'all if you want to accept or close the PR :(

@MikailBag
Copy link
Contributor

MikailBag commented Feb 6, 2025

Thank you for your fix. Our lawyers made us do this :(

To be clear, adopting the CLA boils down to writing one comment.

https://github.com/yandex/perforator/blob/main/CONTRIBUTING.md#provide-contributions

If you still prefer to reject it, I'll see if there is some way around.

@ivoanjo
Copy link
Author

ivoanjo commented Feb 7, 2025

Thank you for your fix. Our lawyers made us do this :(

To be clear, adopting the CLA boils down to writing one comment.

Yeah, I can imagine 😓 . The problem is our lawyers (I work at Datadog) require reviewing any CLAs we sign, which is a lot of complexity for a typo fix. So that's what I was thinking of when I said "I don't think it's worth my time chasing it" -- it's because it's not just me reading and agreeing.

Apologies if I created a bit of a confusion -- my intention was to only do a tiny drive-by fix as I was reading through the file.

@MikailBag MikailBag self-assigned this Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants