Skip to content

Resume always-ask tool confirmations - #9

Merged
yanpgwang merged 1 commit into
mainfrom
codex/tool-confirmation-resume
Jul 28, 2026
Merged

Resume always-ask tool confirmations#9
yanpgwang merged 1 commit into
mainfrom
codex/tool-confirmation-resume

Conversation

@yanpgwang

Copy link
Copy Markdown
Owner

Summary

  • resume single built-in always_ask tool confirmations from the durable pending-action gate
  • execute the original server-owned tool call on allow and emit its correlated agent.tool_result
  • skip all execution on deny and deliver a correlated rejection result containing deny_message
  • reject malformed/mismatched confirmations before any side effect
  • preserve strict Messages role alternation when a parked response contained both text and tool use
  • document multi-action, MCP, exact rejection wording, and crash-replay limitations without expanding scope

Verification

  • go test ./...
  • go test -race ./...
  • go vet ./...
  • confirmation runtime tests repeated 50 times
  • confirmation allow/deny app tests repeated 20 times
  • event-variant validation repeated 20 times
  • npm run typecheck
  • npm run build
  • git diff --check

@yanpgwang
yanpgwang merged commit e2f0e35 into main Jul 28, 2026
2 checks passed
@yanpgwang
yanpgwang deleted the codex/tool-confirmation-resume branch July 28, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant