Fix updatepreferred to handle JLC API changes#154
Open
z2amiller wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that at some point, JLC has changed the way it reports the page numbering when
iterating the preferred components. I noticed this while I was investigating another issue, that
there were exactly 1000 preferred components, that seemed suspiciously like a hardcoded limit.
It looks like the API response from JLC has changed, and it reports 'hasNextPage: false' even when
there are remaining pages. It looks like the API now reports the number of pages and the current
page, so I've changed the updatepreferred command to use this instead.
With and without the change:
(I assume that 1234 != 1232 due to some parsing/etc issue somewhere but it's small enough that I didn't look into it further)