Skip to content

feat: add default width to Deno implementation #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

shadowspawn
Copy link
Member

@shadowspawn shadowspawn commented May 27, 2023

Just a small improvement. Use Deno.consoleSize to supply default value for column width.

Noted in: #132 (comment) and was included in closed #140

@bcoe
Copy link
Member

bcoe commented May 13, 2025

@shadowspawn still something you'd like to land?

@shadowspawn
Copy link
Member Author

Yes thanks, I'll resolve conflicts hopefully in next few days or so.

@shadowspawn
Copy link
Member Author

shadowspawn commented May 18, 2025

I did a bunch of hacking about with this again, but questioning whether worthwhile.

  • the Deno support for Node.js libraries is now very good
  • Deno has moved on from deno.land to JSR

I wonder if the better direction than landing this PR is to confirm Deno works fine with npmjs published cliui and perhaps drop the separate Deno code and publish!

@shadowspawn
Copy link
Member Author

Note to self, declaration for fixing standard and tsc complaints about Deno global being undefined:

declare const Deno: typeof globalThis.Deno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants