drop unused reports (see https://github.com/openSUSE/libzypp/pull/610) #191
+59
−412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreidinger
force-pushed
the
drop_unused_report
branch
2 times, most recently
from
c2b1b9b to
a087997
Compare
lslezak
reviewed
Jan 31, 2025
| * @param string args Name of the callback handler function. Required callback prototype is <code>void(string url)</code>. The callback is evaluated when a source creation has been started. | ||
| * @return void | ||
| */ | ||
| YCPValue PkgFunctions::CallbackSourceCreateStart( const YCPValue& args) | ||
| { | ||
| return SET_YCP_CB( CB_SourceCreateStart, args); | ||
| return YCPVoid(); |
There was a problem hiding this comment.
I'd add some logging to easily find the obsolete calls in the Ruby code:
ycpmilestone("Pkg::CallbackSourceCreateStart is obsolete and does nothing, remove it");This logs the Ruby place where it was called from.
(Needs #include <ycp/y2log.h> at the top.)
There was a problem hiding this comment.
looks like there is already #include "log.h" which should include y2util/y2log which hopefully should be enough.
There was a problem hiding this comment.
hmm, it defined y2milestone and not ycpmilestone. Let me check if there is difference between them.
There was a problem hiding this comment.
ok, there is different y2milestone report file nad location when it is called. ycpmilestone will use yast info about location, so probably the right ruby location. So lets add that header.
jreidinger
force-pushed
the
drop_unused_report
branch
from
0306535 to
b0ffbf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Libzypp has bunch of unused reports and pkg-bindings still use it.
openSUSE/libzypp#610
Solution
make them noop and mark as deprecated.