Replace SessionManager by SessionFactory #1477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arigachnyy
force-pushed
the
refactor-session-manager
branch
from
e7b2c3f to
e7af94a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
В SessionManager не надо хранить список открытых сессий, потому что с SessionManager работает только EndpointManager, который уже хранит список открытых ендпоинтов с их сессиями. Таким образом из SessionManager можно вместе со списком сессий удалить все проверки на то что сессия уже открыта и т.д. Все эти проверки уже есть в EndpointManager. Таким образом это будет уже не SessionManager, а SessionFactory.