-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Disk Manager] Support creation disks in scale units #3185
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isk in scale unit zone
BarkovBG
reviewed
Mar 13, 2025
Rattysed
commented
Mar 17, 2025
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
BarkovBG
reviewed
Mar 17, 2025
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
Rattysed
commented
Mar 20, 2025
Rattysed
commented
Mar 20, 2025
Rattysed
commented
Mar 20, 2025
Rattysed
commented
Mar 20, 2025
Rattysed
commented
Mar 20, 2025
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
Rattysed
commented
Mar 20, 2025
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Show resolved
Hide resolved
Rattysed
commented
Mar 20, 2025
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Show resolved
Hide resolved
BarkovBG
reviewed
Mar 21, 2025
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Show resolved
Hide resolved
Rattysed
commented
Mar 24, 2025
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
BarkovBG
reviewed
Mar 24, 2025
BarkovBG
reviewed
Mar 24, 2025
BarkovBG
reviewed
Mar 24, 2025
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
BarkovBG
reviewed
Mar 25, 2025
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Show resolved
Hide resolved
BarkovBG
reviewed
Mar 26, 2025
cloud/disk_manager/internal/pkg/facade/disk_service_test/common_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_sharded_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/facade/disk_service_test/disk_service_test.go
Outdated
Show resolved
Hide resolved
BarkovBG
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
disk_manager
Add this label to run only cloud/disk_manager build and tests on PR
large-tests
Launch large tests for PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3184
Also supported deletion disks in SUs.
Some tests were updated to cover multiple creation zone options