Skip to content

[Blobstore] delete obsolete uncofirmed blobs #4710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
neihar wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[Blobstore] delete obsolete uncofirmed blobs #4710

neihar wants to merge 6 commits into from

Conversation

@neihar
Copy link
Collaborator

@neihar neihar commented Nov 23, 2025 •
edited
Loading

Currently, if we receive error during WriteMergedBlocks, unconfirmed blobs left in the table until next restart.
This PR resolves this problem by cleaning table from unwanted blobs.
On restart we will have less amount of blobs to confirm with BS

@neihar neihar force-pushed the users/ihar/handle-unconfirm-blobs-always branch from 52f7757 to 7f315b1 Compare November 23, 2025 22:25
Base automatically changed from users/ihar/improve-unconfirmed-blobs to main November 25, 2025 09:05
@neihar neihar force-pushed the users/ihar/handle-unconfirm-blobs-always branch from 7f315b1 to 685933d Compare November 26, 2025 11:03
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 685933d.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
9615 9614 0 0 0 1 0

@neihar neihar requested a review from SvartMetal November 26, 2025 12:47
@neihar neihar changed the title [Blobstore] delete stalled uncofirmed blobs [Blobstore] delete obsolete uncofirmed blobs Nov 26, 2025
@neihar neihar marked this pull request as draft November 26, 2025 12:53
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit ec63582.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
9615 9614 0 0 0 1 0

@neihar neihar force-pushed the users/ihar/handle-unconfirm-blobs-always branch from ec63582 to a115144 Compare December 3, 2025 11:24
neihar
neihar commented Dec 3, 2025
View reviewed changes
@neihar neihar marked this pull request as ready for review December 3, 2025 11:32
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit bfa7dbf.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
9637 9636 0 0 0 1 0

SvartMetal
SvartMetal reviewed Dec 3, 2025
View reviewed changes
cloud/blockstore/libs/storage/partition/part_actor_writeblocks.cpp Outdated
TEvPartitionPrivate::TEvDeleteObsoleteUnconfirmedBlobsRequest>(
MakeIntrusive<TCallContext>(CreateRequestId()),
commitId,
std::move(msg->BlobsToConfirm));
Copy link
Collaborator

@SvartMetal SvartMetal Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

может просто удалим все блобы соответствующего коммита?

Copy link
Collaborator Author

@neihar neihar Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

по идее это должно быть редкое событие, наверное можно прям тут ExecuteTx, переделаю

Copy link
Collaborator

@SvartMetal SvartMetal Dec 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я имел ввиду, не нужно ли удалить все блобы соответствующего коммита, то есть, может быть не нужно передавать BlobsToConfirm?

кажется стоит так делать ради атомарности

Copy link
Collaborator Author

@neihar neihar Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

да, так будет более правильно, но в данном случае результат будет всегда тот же самый, поправил

SvartMetal
SvartMetal reviewed Dec 3, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025 •
edited
Loading

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 85ba1f6.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
9637 9635 0 1 0 1 0

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 85ba1f6.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
45 45 0 0 0 0 0

SvartMetal
SvartMetal reviewed Dec 4, 2025
View reviewed changes
@neihar neihar force-pushed the users/ihar/handle-unconfirm-blobs-always branch from 85ba1f6 to 323150f Compare December 4, 2025 11:28
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 323150f.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
9637 9636 0 0 0 1 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SvartMetal SvartMetal SvartMetal left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neihar @SvartMetal