[Disk Manager] Prepare cells storage for metrics #4728

Rattysed · 2025-11-26T16:16:35Z

Preparing the cells storage for metrics. Removing redundant structure clusterCapacityState, making CreatedAt field public in cells.ClusterCapacity

github-actions · 2025-11-26T16:45:07Z

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit ce6c4c3.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1235	1226	0	6	0	3	0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit ce6c4c3.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
76	67	0	6	0	3	0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit ce6c4c3.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
76	67	0	6	0	3	0

github-actions · 2025-11-26T22:36:09Z

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 613fcce.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1235	1228	0	4	0	3	0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 613fcce.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
72	65	0	4	0	3	0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 613fcce.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
72	65	0	4	0	3	0

github-actions · 2025-11-26T23:30:35Z

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 45c3f99.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
945	938	0	4	0	3	0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 45c3f99.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
72	65	0	4	0	3	0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 45c3f99.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
72	65	0	4	0	3	0

github-actions · 2025-11-27T00:18:32Z

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 7d3a70f.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
945	938	0	4	0	3	0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 7d3a70f.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
162	155	0	4	0	3	0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 7d3a70f.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
72	65	0	4	0	3	0

github-actions · 2025-11-27T01:00:18Z

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 32e1cce.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
945	944	0	1	0	0	0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 32e1cce.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
45	44	0	1	0	0	0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 32e1cce.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
45	44	0	1	0	0	0

github-actions · 2025-11-27T08:46:28Z

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 07609d1.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
945	945	0	0	0	0	0

Rattysed · 2025-11-27T08:56:54Z

cloud/disk_manager/internal/pkg/cells/storage/storage_test.go


+// Uses WithinDuration to compare CreatedAt field correctly, since == may fail
+// due to different internal representations.
+func requireClusterCapacitiesAreEqual(


В комменте отписал, конечно, но на всякий: таймстемпы сравнивать через require.Equal нельзя, т.к. после записи в БД они чуть-чуть меняются

Rattysed · 2025-11-27T08:58:32Z

cloud/disk_manager/internal/pkg/cells/storage/storage_test.go

-		capacity1,
-		cellCapacity1,
-	}, capacities)
+	sort.Slice(capacities, func(i, j int) bool {


Порядок получения из GetRecentClusterCapacitites не детерминирован. Имхо, ради тестов его фиксировать бессмысленно. Так что проще отсортировать на месте

Rattysed · 2025-11-27T09:06:32Z

cloud/disk_manager/internal/pkg/cells/collect_cluster_capacity_task_test.go


 ////////////////////////////////////////////////////////////////////////////////

+func matchClusterCapacities(t *testing.T, expected cells_storage.ClusterCapacity) interface{} {


Теперь CreatedAt задаём в коде таски, нужно сверять время. Обычно в таких случаях мы просто подставляем mock.Anything, но тут терялся бы смысл теста.

В матчере сравниваем полученное время с time.Now(), т.к. такой же time.Now() выставляется в коде таски. Минута про запас

github-actions · 2025-11-27T09:45:29Z

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 05f3b8c.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1235	1235	0	0	0	0	0

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

gy2411 · 2025-12-01T16:56:43Z

cloud/disk_manager/internal/pkg/cells/collect_cluster_capacity_task_test.go

+			expected.TotalBytes != got.TotalBytes ||
+			expected.CellID != got.CellID || expected.Kind != got.Kind ||
+			expected.ZoneID != got.ZoneID ||
+			time.Now().Sub(got.CreatedAt).Abs() >= time.Minute {


Давай сначала сделаем проверку на время, потом приравняем время и сравним expected и got целиком на равенство? А то если в структуру потом добавится новое поле, то тут легко забыть добавить проверку.

Логично. Исправил в обоих тестах

github-actions · 2025-12-03T12:07:33Z

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit a241e61.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1235	1235	0	0	0	0	0

remove clusterCapacityState

ce6c4c3

Rattysed added large-tests Launch large tests for PR disk_manager Add this label to run only cloud/disk_manager build and tests on PR labels Nov 26, 2025

Rattysed added 2 commits November 26, 2025 21:39

fix ydb scan

c7a9482

fix storage tests

613fcce

support time.Equal in tests

45c3f99

Rattysed removed the large-tests Launch large tests for PR label Nov 26, 2025

fix capacity task test

7d3a70f

finally all tests are fixed

32e1cce

set correct value in tests

07609d1

Rattysed added the large-tests Launch large tests for PR label Nov 27, 2025

Rattysed commented Nov 27, 2025

View reviewed changes

Rattysed added 2 commits November 27, 2025 09:01

simplify matchClusterCapacities

cd382e1

return time check into matchClusterCapacities

420c108

Rattysed commented Nov 27, 2025

View reviewed changes

Rattysed marked this pull request as ready for review November 27, 2025 09:15

fix build

05f3b8c

Rattysed requested review from BarkovBG and jkuradobery November 27, 2025 09:19

jkuradobery requested a review from Copilot November 27, 2025 10:22

Copilot started reviewing on behalf of jkuradobery November 27, 2025 10:38 View session

Copilot finished reviewing on behalf of jkuradobery November 27, 2025 10:40

Copilot AI reviewed Nov 27, 2025

View reviewed changes

gy2411 reviewed Dec 1, 2025

View reviewed changes

change ClusterCapacity comparation logic

a241e61


		////////////////////////////////////////////////////////////////////////////////

		func matchClusterCapacities(t *testing.T, expected cells_storage.ClusterCapacity) interface{} {

[Disk Manager] Prepare cells storage for metrics #4728

Are you sure you want to change the base?

[Disk Manager] Prepare cells storage for metrics #4728

Uh oh!

Conversation

Rattysed commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 27, 2025

Uh oh!

Rattysed Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Rattysed Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Rattysed Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 27, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

gy2411 Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Rattysed Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Rattysed commented Nov 26, 2025 •

edited

Loading

github-actions bot commented Nov 26, 2025 •

edited

Loading

github-actions bot commented Nov 26, 2025 •

edited

Loading

github-actions bot commented Nov 26, 2025 •

edited

Loading

github-actions bot commented Nov 27, 2025 •

edited

Loading

github-actions bot commented Nov 27, 2025 •

edited

Loading