[Blockstore] blockstore-client: make ignore unknown nbs-client.txt config params #4733
Conversation
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit c108692.
🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit c108692.
|
nisqatsi
added
the
recheck
github-actions
bot
removed
the
recheck
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit c108692.
🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit c108692.
|
| NProto::TClientAppConfig appConfig; | ||
| if (NFs::Exists(ConfigFile)) { | ||
| ParseFromTextFormat(ConfigFile, appConfig); | ||
| ParseFromTextFormat(ConfigFile, appConfig, EParseFromTextFormatOption::AllowUnknownField); |
There was a problem hiding this comment.
Completely ignoring unknown fields is a bit dangerous, let's at least log them - you can do it easily via the third ParseFromTextFormat() parameter - warningStream
There was a problem hiding this comment.
simple Cerr would suffice
nisqatsi
force-pushed
the
users/usenkoav/NBS_6385-blockstore_client-ignore_unknown_conf_params
branch
from
c108692 to
1f4f506
Compare
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 1f4f506.
🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 1f4f506.
|
| NProto::TClientAppConfig appConfig; | ||
| if (NFs::Exists(ConfigFile)) { | ||
| ParseFromTextFormat(ConfigFile, appConfig); | ||
| ParseFromTextFormat(ConfigFile, appConfig, EParseFromTextFormatOption::AllowUnknownField, &GetOutputStream()); |
There was a problem hiding this comment.
GetOutputStream() -> GetErrorStream()
| if (NFs::Exists(ConfigFile)) { | ||
| ParseFromTextFormat(ConfigFile, appConfig); | ||
| ParseFromTextFormat(ConfigFile, appConfig, EParseFromTextFormatOption::AllowUnknownField, &GetOutputStream()); | ||
| GetOutputStream() << Endl; |
There was a problem hiding this comment.
if ParseFromTextFormat doesn't print a \n to this stream, then it's better to use TStringStream ss and then do something like
if (ss.Str().Size()) {
GetErrorStream() << ss.Str() << '\n';
}
Now blockstore-client silently ignores unknown params in nbs-client.txt config file.