issue-4734: added executable for writing pid to cgroup file #4735

vladstepanyuk · 2025-11-28T10:30:47Z

#4734

cloud/blockstore/libs/endpoints_vhost/external_vhost_server.cpp

cloud/blockstore/libs/common/cgroups_helpers.cpp

cloud/blockstore/libs/common/cgroups_helpers.h

cloud/blockstore/libs/endpoints_vhost/external_vhost_server.cpp

cloud/blockstore/tools/cgroup-pid-writer/ya.make

komarevtsev-d · 2025-11-28T12:38:26Z

cloud/blockstore/tools/cgroup-pid-writer/main.cpp

+
+int main(int argc, char** argv)
+{
+    if (argc < 3) {


Давай сюда вставим Y_ABORT_UNLESS под макросом NDEBUG что путь в sys/fs/cgroup?
Тогда в тестах оно стрелять не будет

может достаточно будет написать тесты на функции хелперы? ведь бинарь только парсит входные аргументы и вызывает вспомогательные функции

Путь можно в параметре передавать:

blockstore-cgroup-pid-writer --cgroup-base-path 'test-path/cgroup' ...

нужно какую-то защиту иметь что мы меняем только файлы внутри "/sys/fs/cgroup" а так если будем передавать --cgroup-base-path 'test-path/cgroup' снаружи, то любой сможет вызвать этот бинарь и поменять файлы в каких попало директориях

cloud/blockstore/libs/common/cgroups_helpers.cpp

cloud/blockstore/config/server.proto

cloud/blockstore/tools/cgroup-pid-writer/main.cpp

github-actions · 2025-11-28T15:02:26Z

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit d074cb2.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
5971	5966	0	2	0	3	0

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit d074cb2.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
310	310	0	0	0	0	0

github-actions · 2025-12-02T16:38:53Z

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 72fbfeb.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
5973	5972	0	0	0	1	0

github-actions · 2025-12-04T15:09:26Z

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit cddacfb.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
6004	6003	0	0	0	1	0

sharpeye · 2025-12-02T17:54:37Z

cloud/blockstore/tools/cgroup-pid-writer/main.cpp

+
+int main(int argc, char** argv)
+{
+    if (argc < 3) {


Почему бы не заиспользовать last_getopt.h ?

8675fcb

cloud/blockstore/tools/cgroup-pid-writer/main.cpp

sharpeye · 2025-12-04T17:01:59Z

cloud/blockstore/tools/cgroup-pid-writer/main.cpp

@@ -0,0 +1,39 @@
+#include <cloud/blockstore/libs/common/cgroups_helpers.h>


Не уверен, что ради двух мелких функций стоит это делать, особенно в common - можно просто накопипастить.

нужно написать какие-то тесты, при этом написать интеграционные тесты, запускающие бинарь не получится, т.к. мы хотим зашить проверку внутрь бинаря на то, что изменяются только файлы внутри /sys/fs/cgroup

и передавать снаружи этот путь нельзя

Передаешь тестовый путь через параметр --cgroup-root-path - пишешь тесты с запуском бинаря. По умолчанию путь на /sys/fs/cgroup - какие проблемы?

cloud/blockstore/tools/cgroup-pid-writer/main.cpp

sharpeye · 2025-12-04T17:14:03Z

cloud/blockstore/tools/cgroup-pid-writer/main.cpp

+
+int main(int argc, char** argv)
+{
+    if (argc < 3) {


Путь можно в параметре передавать:

blockstore-cgroup-pid-writer --cgroup-base-path 'test-path/cgroup' ...

cloud/blockstore/libs/endpoints_vhost/external_vhost_server.cpp

sharpeye · 2025-12-04T19:50:49Z

cloud/blockstore/libs/endpoints_vhost/external_vhost_server.cpp

+            if (ExternalCgroupsPidWriterBinaryPath) {
+                AddToCGroupsWithExternalExecutable(
+                    ExternalCgroupsPidWriterBinaryPath,
+                    process.Pid,
+                    Cgroups);
+            } else {
+                AddToCGroups(process.Pid, Cgroups);
+            }


Это лучше вынести, чтоб не раздувать StartProcess 2ca98f7

github-actions · 2025-12-08T09:53:01Z

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit efd5982.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
6004	6003	0	0	0	1	0

sharpeye · 2025-12-08T09:56:16Z

cloud/blockstore/tools/cgroup-pid-writer/main.cpp

@@ -0,0 +1,39 @@
+#include <cloud/blockstore/libs/common/cgroups_helpers.h>


Передаешь тестовый путь через параметр --cgroup-root-path - пишешь тесты с запуском бинаря. По умолчанию путь на /sys/fs/cgroup - какие проблемы?

cloud/blockstore/libs/common/cgroups_helpers.cpp

vladstepanyuk added large-tests Launch large tests for PR blockstore Add this label to run only cloud/blockstore build and tests on PR labels Nov 28, 2025

vladstepanyuk commented Nov 28, 2025

View reviewed changes

cloud/blockstore/libs/endpoints_vhost/external_vhost_server.cpp Show resolved Hide resolved

vladstepanyuk commented Nov 28, 2025

View reviewed changes

cloud/blockstore/libs/endpoints_vhost/external_vhost_server.cpp Outdated Show resolved Hide resolved

vladstepanyuk requested a review from komarevtsev-d November 28, 2025 12:34

sharpeye reviewed Nov 28, 2025

View reviewed changes

komarevtsev-d reviewed Nov 28, 2025

View reviewed changes

sharpeye reviewed Nov 28, 2025

View reviewed changes

cloud/blockstore/tools/cgroup-pid-writer/main.cpp Outdated Show resolved Hide resolved

cloud/blockstore/tools/cgroup-pid-writer/main.cpp Outdated Show resolved Hide resolved

cloud/blockstore/tools/cgroup-pid-writer/main.cpp Outdated Show resolved Hide resolved

vladstepanyuk requested review from komarevtsev-d and sharpeye December 2, 2025 14:25

vladstepanyuk added 5 commits December 4, 2025 12:44

issue-4734: added executable for writing pid to cgroup file

8a705c8

revert some change

33c0388

corrected issues and added cgroup dir check

7b7f80c

corrected issues

832de7f

removed peerdir

cddacfb

vladstepanyuk force-pushed the users/vladstepanyuk/issue-4734/0 branch from 72fbfeb to cddacfb Compare December 4, 2025 12:47

sharpeye reviewed Dec 4, 2025

View reviewed changes

corrected issues

ab978a4

vladstepanyuk requested a review from sharpeye December 8, 2025 07:30

pass pid to executable right way

efd5982

sharpeye reviewed Dec 8, 2025

View reviewed changes

corrected issues

0638599

vladstepanyuk requested a review from sharpeye December 8, 2025 13:03

		@@ -0,0 +1,39 @@
		#include <cloud/blockstore/libs/common/cgroups_helpers.h>

issue-4734: added executable for writing pid to cgroup file #4735

Are you sure you want to change the base?

issue-4734: added executable for writing pid to cgroup file #4735

Conversation

vladstepanyuk commented Nov 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vladstepanyuk Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Nov 28, 2025 •

edited

Loading

vladstepanyuk Dec 8, 2025 •

edited

Loading